Skip to content

fix(stovepipe): Support older proto generators #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prathshenoy merged 1 commit into from
Sep 22, 2026
+158 −80
Merged

fix(stovepipe): Support older proto generators #739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions api/stovepipe/proto/stovepipe.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,9 @@ message ProjectValidation {
// Stable consumer-defined project identifier.
string project = 1;
// Breakage degree on [0.0, 1.0]. Zero is green; absence means no result is recorded yet.
optional double breakage_degree = 2;
oneof result {
double breakage_degree = 2;
}
}

// GetProjectStatusByURIResponse contains the selected validation's current projection.
Expand All @@ -144,7 +146,9 @@ message GetProjectStatusByURIResponse {
// Unix millisecond timestamp of the newest durable lifecycle or result record.
int64 updated_at_ms = 10;
// Whole-repository breakage degree. Absent until the result is durable.
optional double repository_breakage_degree = 6;
oneof repository_result {
double repository_breakage_degree = 6;
}
// True after the implementation has durably finished producing relevant project results.
bool project_results_complete = 7;
// Recorded results for requested projects.
Expand Down
87 changes: 69 additions & 18 deletions api/stovepipe/protopb/stovepipe.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

111 changes: 55 additions & 56 deletions api/stovepipe/protopb/stovepipe.pb.yarpc.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 7 additions & 3 deletions service/stovepipe/server/mapper/project_status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,18 @@ func GetProjectStatusByURIResultToProto(result entity.GetProjectStatusByURIResul
NextPageToken: result.NextPageToken,
}
if result.HasRepositoryValidationFact {
response.RepositoryBreakageDegree = &result.RepositoryValidationFact.Degree
response.RepositoryResult = &pb.GetProjectStatusByURIResponse_RepositoryBreakageDegree{
RepositoryBreakageDegree: result.RepositoryValidationFact.Degree,
}
}
response.Projects = make([]*pb.ProjectValidation, 0, len(result.ProjectValidationFacts))
for _, fact := range result.ProjectValidationFacts {
degree := fact.Degree
response.Projects = append(response.Projects, &pb.ProjectValidation{
Project: fact.Project,
BreakageDegree: &degree,
Project: fact.Project,
Result: &pb.ProjectValidation_BreakageDegree{
BreakageDegree: degree,
},
})
}
return response
Expand Down
Loading
Loading