Skip to content

fix(stovepipe): Support older proto generators - #739

Merged
prathshenoy merged 1 commit into
mainfrom
prath.shenoy/proto-oneof-presence
Sep 22, 2026
Merged

prathshenoy merged 1 commit into
mainfrom
prath.shenoy/proto-oneof-presence

Conversation

@prathshenoy

@prathshenoy prathshenoy commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

What:

  • Replace optional validation-result fields with oneof fields.

Why:

  • Keep the API compatible with established internal code generators.

Test Plan

  • Update unit tests.

Revert Plan

  • Revert this PR only after confirming affected consumers support proto3 optional fields, then regenerate bindings and rerun their builds.

Issue Links

**What**:
- Represent recorded validation outcomes with explicit wire-level presence.
- Preserve recorded successful outcomes separately from absent outcomes.

**Why**:
- Support consumers that need to distinguish no result from a green result.
- Keep the API compatible with established code generators.
@prathshenoy prathshenoy changed the title fix(stovepipe): Preserve status field presence fix(stovepipe): Support older proto generators Sep 22, 2026
@prathshenoy
prathshenoy marked this pull request as ready for review September 22, 2026 22:33
@prathshenoy
prathshenoy added this pull request to the merge queue Sep 22, 2026
Merged via the queue into main with commit 8d781d5 Sep 22, 2026
29 checks passed
@behinddwalls
behinddwalls deleted the prath.shenoy/proto-oneof-presence branch September 22, 2026 22:38

This branch was successfully deployed

1 active deployment
stack-rebase 5c530c58 Deployed Sep 22, 2026 by prathshenoy via Rebase Stack #531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants