refactor(ui): centralize destructive ghost button colors in EMCN - #7988
Open
BillLeoutsakosvl346 wants to merge 1 commit into
Open
BillLeoutsakosvl346 wants to merge 1 commit into
BillLeoutsakosvl346 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eleven product delete/remove buttons override EMCN Button colors locally. Add
ghost-destructive(red at rest and on hover) andghost-destructive-muted(muted at rest, red on hover) to the existing Button, and migrate all nine always-red and two muted consumers. Both use existing global color tokens.The rendered class sets are identical. Geometry, icons, labels, handlers, disabled conditions, native button behavior and the input-format button's hover opacity remain unchanged. Existing Button variants and defaults are unchanged.
Product only: 12 source files, with landing excluded. All audit tooling and browser fixtures stay outside the branch; no dependencies or new tests.
Testing
git diff --checkpassed.