Skip to content

refactor(ui): centralize destructive ghost button colors in EMCN - #7988

Open
BillLeoutsakosvl346 wants to merge 1 commit into
stagingfrom
codex/control-fix-destructive-ghost-buttons
Open

BillLeoutsakosvl346 wants to merge 1 commit into
stagingfrom
codex/control-fix-destructive-ghost-buttons

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

Eleven product delete/remove buttons override EMCN Button colors locally. Add ghost-destructive (red at rest and on hover) and ghost-destructive-muted (muted at rest, red on hover) to the existing Button, and migrate all nine always-red and two muted consumers. Both use existing global color tokens.

The rendered class sets are identical. Geometry, icons, labels, handlers, disabled conditions, native button behavior and the input-format button's hover opacity remain unchanged. Existing Button variants and defaults are unchanged.

Product only: 12 source files, with landing excluded. All audit tooling and browser fixtures stay outside the branch; no dependencies or new tests.

Testing

  • 343 existing EMCN tests passed; EMCN/app type checks, repository lint, API validation and git diff --check passed.
  • Consumer AST comparison confirms only the variant and color classes changed at all 11 locations.
  • Real before/after Button and Trash renders have identical markup after class-order normalization. 110 Chromium comparisons match in light/dark idle, hover, focus, active and disabled states using compiled app CSS. All 210 existing variant/size/padding combinations render identical markup. These are isolated component checks, not end-to-end product navigation.
  • Final external category audit: 22 color overrides across 11 buttons → 0. Broader findings 1003 → 981, with unrelated findings unchanged. Full inventory still has unrelated findings and analysis gaps. Landing diff is empty.
  • Committed-diff audit: zero usage violations; four expected central-definition notices for the two new color variants.

@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 18, 2026 10:42pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 12 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the refactor preserves the effective classes and behavior of every migrated button.

Summary

This PR centralizes destructive ghost-button colors in the shared EMCN Button component.

  • Adds always-red and muted-until-hover destructive ghost variants using existing color tokens.
  • Migrates nine always-red and two muted delete/remove controls to the shared variants.
  • Preserves consumer-specific sizing, interaction handlers, disabled conditions, and input-format hover opacity.

Reviews (1) · Last reviewed commit: "refactor(emcn): centralize destructive g..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant