You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Nine product Copy, Search and Expand buttons repeat transparent overlay styling in log details, workflow previews and the deployment preview. Add EMCN OverlayActionButton, built on the existing Button, and migrate all nine locations across four consumer files.
The component owns its 20px/28px geometry, border, background blur and one adaptive hover treatment: surface-3 in light mode and surface-5 in dark mode. The four workflow-preview actions previously used surface-4 on hover; their hover fill changes from #f5f5f5 to #f7f7f7 in light mode and #292929 to #363636 in dark mode. Resting appearance, sizes, corners and behavior stay unchanged. The canonical --border token replaces its equivalent --border-1 alias.
Product code keeps positioning, icons, copy feedback, tooltips, labels and handlers. The specialized component excludes inherited styling props that cannot meaningfully affect its geometry. Existing Button, landing pages and global CSS are unchanged. Audit tooling and screenshots remain outside this PR.
Validation
346 EMCN tests pass across 33 suites, including both preserved adaptive sizes, native ref/prop/event forwarding, tooltip composition and disabled clicks.
All 26 workspace type checks and lint checks, API validation, import-specifier checks and diff checks pass.
Light/dark browser checks of the real components with compiled application CSS confirm the intended hover colors and unchanged 20px geometry and 5px corners. Matching screenshots and 3× crops are saved externally; this is isolated component coverage, not full product navigation.
Product searches find no remaining old overlay recipes or retired overlay surface props. The initial category migration removed all 52 targeted findings; unrelated audit findings remain outside this change.
The PR appears safe to merge; the shared component preserves the migrated controls’ contracts and the previously missing focused coverage is now present.
Summary
This PR introduces a shared EMCN OverlayActionButton and migrates nine copy, search, and expand controls to it.
Centralizes overlay geometry, border, blur, and adaptive hover styling.
Preserves consumer-owned positioning, icons, labels, handlers, and tooltip composition.
Adds focused coverage for both supported sizes, markup compatibility, ref and native-prop forwarding, keyboard events, and disabled clicks.
The previously reported missing-test finding is fully addressed by the current test suite.
@greptileai please re-review PR #7990 at commit 7a463bc. Added four focused OverlayActionButton test cases following the existing action-button conventions: the three migrated appearances (both sizes and hover treatments, with Button class precedence), plus native ref/prop/event forwarding through Tooltip and disabled-click suppression. All 347 EMCN tests, type checks, repository lint and API validation pass. Runtime source is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Summary
Nine product Copy, Search and Expand buttons repeat transparent overlay styling in log details, workflow previews and the deployment preview. Add EMCN
OverlayActionButton, built on the existing Button, and migrate all nine locations across four consumer files.The component owns its 20px/28px geometry, border, background blur and one adaptive hover treatment: surface-3 in light mode and surface-5 in dark mode. The four workflow-preview actions previously used surface-4 on hover; their hover fill changes from #f5f5f5 to #f7f7f7 in light mode and #292929 to #363636 in dark mode. Resting appearance, sizes, corners and behavior stay unchanged. The canonical
--bordertoken replaces its equivalent--border-1alias.Product code keeps positioning, icons, copy feedback, tooltips, labels and handlers. The specialized component excludes inherited styling props that cannot meaningfully affect its geometry. Existing Button, landing pages and global CSS are unchanged. Audit tooling and screenshots remain outside this PR.
Validation