feat: add iputils-ping to both images for asset discovery - #176
Merged
Merged
Conversation
Asset discovery relies on ping, which neither the Ubuntu nor the php:*-apache base image ships. Add iputils-ping to the apt install lists in both generators and regenerate the Dockerfiles. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iputils-pingto the apt install lists in bothgenerate_dockerfile.shscripts and regenerate the Dockerfiles (no version bump).ping, which neither the Ubuntu nor thephp:*-apachebase image ships, so neither image had it.Test plan
simplerisk-minimallocally and ranping -c1 127.0.0.1as the non-rootsimpleriskuser: succeeds.NET_RAW, which Docker grants by default; deployments that drop it (e.g. k8sdrop: ALL) will still fail.🤖 Generated with Claude Code