feat: install ping on all supported distros for asset discovery - #46
Merged
Merged
Conversation
SimpleRisk's asset discovery relies on ping, which minimal server and cloud images often omit. Install iputils-ping (Debian/Ubuntu) or iputils (RHEL family, SUSE) and add an install-verification check. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iputils-ping(Debian/Ubuntu) /iputils(RHEL family, SUSE) in each distro path ofsimplerisk-setup.sh.ping is installedcheck totests/verify-install.sh.ping; minimal server/cloud images often omit it, and none of the distro test images had it. Companion to feat: add iputils-ping to both images for asset discovery docker#176.Test plan
bash -non both scripts.pingis present on every distro).🤖 Generated with Claude Code