Skip to content

fix: guard Howler rate calls when sound pool is empty #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dazzatronus merged 1 commit into from
Sep 25, 2026
Merged

fix: guard Howler rate calls when sound pool is empty #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/components/canvas/players/audio-player.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ export class AudioPlayer extends Player {

this.getContainer().alpha = 0;

if (!this.audioResource) {
if (!this.audioResource || this.audioResource.state() !== "loaded") {
this.isPlaying = false;
return;
}

Expand All @@ -82,7 +83,8 @@ export class AudioPlayer extends Player {
this.audioResource.volume(this.getVolume());
}

if (this.audioResource.rate() !== speed) {
// Howler's rate getter dereferences the first sound, which may not exist after teardown.
if (this.audioResource.playing() && this.audioResource.rate() !== speed) {
this.audioResource.rate(speed);
}

Expand Down
Loading