fix: guard Howler rate calls when sound pool is empty - #189
Merged
Merged
Conversation
dazzatronus
force-pushed
the
fix/howler-rate-empty-sounds
branch
from
September 25, 2026 00:28
5a3e4b8 to
ea1b63e
Compare
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 25, 2026
## [2.22.3](v2.22.2...v2.22.3) (2026-09-25) ### Bug Fixes * guard audio rate reads without blocking playback recovery ([#189](#189)) ([45306dd](45306dd))
|
🎉 This PR is included in version 2.22.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Howler's rate getter throws when its sound pool is empty. Skip unloaded resources and read the rate only while a sound is playing, so
play()can still create a sound when a loaded pool is empty.Verify:
npm run verify:cipasses on Node 22, including 2,084 tests.