Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 5 5
Lines 364 364
=======================================
Hits 361 361
Misses 3 3
🚀 New features to boost your workflow:
|
|
@Akadib @stevenhua0320 please can you report the results of your acceptance testing? I can only merge this when I know that the program still works as expected. Also, please discuss if you will do the documentation and requirements work on this PR or on a separate one, in which case, please create an issue that we can close. |
|
@Akadib You could do this from both |
|
Pytest is ok, it is handled in CI so it is not needed to be posted here. But paste here some kind of summary of the results of the integration testing (running the examples) |
|
OK, at least when I compute these PR change on my machine it should be fine: But for learning purpose, @Akadib you should try to replicate it. |
|
Thanks @stevenhua0320. be clear, i am less interested in unit tests as these are passing in CI. I am asking Adib to run the program and do the examples (assuming there are examples) to learn what the program does and make sure it runs in the same way after the migration. |
Yeah, I had a meeting before with Adib and I think he would do it (both |
@sbillinge Read to review. Most of the changes made from the last PR that Rundong committed. Changed the news item to fix, deleted the auto-generated file, and link the CLI script in the project scripts within pyproject.toml file to the right name.
This PR has covered all the previous comments.