Updated scikit package - #227
stevenhua0320 wants to merge 5 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 5 5
Lines 364 364
=======================================
Hits 361 361
Misses 3 3
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Please install and run the code in the current version to make sure you understand how it works and what it does (there should be some tutorials in the docs) and make sure that it is not broken after the migration, i.e , it works in the same way before and after.
| @@ -0,0 +1,23 @@ | |||
| **Added:** | |||
|
|
|||
| * migrated `labpdfproc` to a latest scikit-package level | |||
There was a problem hiding this comment.
this is probably better as a fixed?
| @@ -0,0 +1,35 @@ | |||
| import argparse | |||
There was a problem hiding this comment.
I think labpdfproc as apps so we probably don't want this auto-generated one. I suggest to run the old version of the code to understand how it works, and then to make sure that it still works the same way after migrating.
| dev_template = "{tag}" | ||
| dirty_template = "{tag}" | ||
|
|
||
| [project.scripts] |
There was a problem hiding this comment.
removing this is probably breaking things too, but do check.
| [tool.setuptools.package-data] | ||
| "diffpy.labpdfproc" = ["data/*"] | ||
|
|
||
| [project.scripts] |
There was a problem hiding this comment.
we probably don't need this
|
Please see comment that I accidentally put on the closed PR about updating requirements and docs as well as the other things. Perhaps they would be better on another PR though? |
|
Just to quote what is being said on the closed PR comment: |
Just a quick question here. I think for |
@sbillinge ready to review. Most of the work done by @Akadib and fix something that could not handle on his laptop. Has reviewed.