Skip to content

Updated scikit package - #226

Closed
Akadib wants to merge 3 commits into
diffpy:mainfrom
Akadib:updated-scikit-package
Closed

Akadib wants to merge 3 commits into
diffpy:mainfrom
Akadib:updated-scikit-package

Conversation

@Akadib

@Akadib Akadib commented Sep 30, 2026

Copy link
Copy Markdown

@stevenhua0320 Ready to review!

@codecov

codecov Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.17%. Comparing base (b1438f2) to head (74b5fc9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #226   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files           5        5           
  Lines         364      364           
=======================================
  Hits          361      361           
  Misses          3        3           
Files with missing lines Coverage Δ
tests/test_version.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevenhua0320

Copy link
Copy Markdown

Closed since done by PR #227

@sbillinge

Copy link
Copy Markdown
Contributor

Closed since done by PR #227

@sbillinge sbillinge closed this Sep 30, 2026

@sbillinge sbillinge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As well as my other comments, please could you also update the docs. I am pretty sure that we can build this with Gooey in 3.14 so changing requirements correspondingly, and the docs and installation instructions to bring things up to date would be good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants