Skip to content

Fix failed action handling - #1271

Merged
EzraBrooks merged 1 commit into
RobotWebTools:developfrom
RoBoa-Robotics:fix/failed-action-handling
Sep 24, 2026
Merged

EzraBrooks merged 1 commit into
RobotWebTools:developfrom
RoBoa-Robotics:fix/failed-action-handling

Conversation

@pascalauroboa

@pascalauroboa pascalauroboa commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Public API Changes
Adds status and result as additional input variables to user provided failedCallback when using actions.

Description
Currently when an action fails regardless if it is the connection layer or the goal itself the failedCallback is called which only provides me with a stringified version of the result. I do not want to parse strings to identify why my action failed. This adds the goal status and result as additional inputs which I can parse in my code. PR #1103 broke previous behaviour where only failed action due to communication executed the failedCallback callback. It is also possible to simplify this by only providing one callback where the user has to distinguish itself what failed or by restoring previous behaviour that the result is irrelevant for the failedCallback.

Closes #1192

@EzraBrooks EzraBrooks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is clearly a better way to do this, thank you.

I dislike/regret the fact that there are still string error messages in this library in general. error here should just be of type GoalError so no string parsing is needed there either. But I guess that's a breaking change and this isn't!

@EzraBrooks
EzraBrooks merged commit f98ccde into RobotWebTools:develop Sep 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User provided callback for failed Actions

2 participants