feat(build): access-gated issue comments enter the build prompt (#9) - #10
Merged
Merged
Conversation
Comments were invisible to agents — post-spec corrections (the #460 retrigger contract) never reached the build. Now: last [pipeline].prompt_comments comments (0 = off, ~16 KB cap) ride along after the body, authors gated by the [access] config (deny > allow > mode, fail-closed), each prefixed '> [comment by <author>, <date>]', under untrusted-data framing. Fetch+gate live in process_issue (which has the forge); _build_prompt stays forge-free. Comment gains a date; GitHub adapter carries created_at. Glossary: Comment context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9
What
Agents only ever saw
issue.body— a maintainer's corrective comment (the #460 audit failure mode) never reached the build. Now the last[pipeline].prompt_commentsissue comments (0 = off, ~16 KB cap) ride along after the body:is_authorized, deny > allow > mode), fail-closed — an author whose role probe errors is out> [comment by <author>, <date>], newest last (Commentgains a date; GitHub adapter carriescreated_at)process_issue(which has the forge) fetches + gates;_build_promptstays forge-free; a read failure degrades to a body-only build, never a fake agent-run failureDecisions settled in the grill session: single int config key (0 = off), fixed 16 KB constant, no devloop-identity carve-out, glossary entry only (no ADR — reversal is cheap).
Follow-up (separate issue):
spec.py::process_specfeeds all comment bodies into the refine prompt ungated — same trust model applies.Verification
Covers the issue's test list: authorized-in / stranger-out / truncation (30 → last 10) / untrusted marker /
{body}regressions / 0 = off.