Skip to content

spec loop feeds all comment bodies into the refine prompt — ungated, unframed #11

Description

@RjBiermann

Problem

devloop/spec.py:process_spec builds the refine prompt as:

f"## Conversation so far\n" + "\n---\n".join(c.body for c in comments)

Every comment body — any author, including agents and strangers — enters the agent prompt with no access gate and no untrusted-data framing. The build side fixed exactly this in #9 / PR #10 (core.comment_block).

Requirements

  1. Route spec-loop comment context through the same seam (comment_block) — gated by cfg.access, untrusted-framed, bounded.
  2. Keep spec_phase's existing authorized-approved check untouched (that's the Ledger-adjacent protocol, not prompt context).
  3. Note: spec conversations are long — decide whether [pipeline].prompt_comments's cap fits the spec loop or spec needs its own key (cheapest: one shared key, raise it for everyone).

Tests

  • spec prompt excludes a non-authorized author's comment
  • untrusted framing present in the spec prompt
  • existing spec-phase transitions unchanged

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions