Conversation
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency stack: main → #768 → #737 → #749 → #771 → #728 → #770 → #763 → #765 → #761 → #742 → #759
Independent follow-ups to #765: #756 (diagnostics), #766 (runtime controls and overhead inspection).
Before this PR
PR #728 combined the issue #754 level-1 acceptance gate with production changes to typed summary state, physical plan lowering, storage identity and ingestion/query bindings. Reviewers could not review the test contract separately from the implementation.
After this PR
Own the existing production changes previously carried by #728: typed exact/summary semantics, physical plan and state bindings, runtime/storage adapters, and their directly coupled regression tests and design documentation. No new execution behavior is introduced by this extraction.
The level-1 acceptance test, its suite/dataset and CI gate remain in #728. This PR is based on #749 and becomes #728's direct base. #770 then consumes the Planner-owned library, followed by #763 and #765.
Validation
The extracted implementation plus #728 produces exactly the original #728 Git tree. Propagating the new parent through #770/#763/#765 preserves each original tree. This is a scope split, not a claim that the outstanding #754 grouped-temporal-Sum and quantile-ratio acceptance failures are resolved.