Conversation
This was referenced Sep 22, 2026
zzylol
force-pushed
the
perf/issue-758
branch
from
September 24, 2026 12:55
4530670 to
999cafd
Compare
zzylol
force-pushed
the
732-test-add-prometheus-remote-write-promql-differential-suite
branch
from
September 24, 2026 12:56
9c84758 to
00195cb
Compare
zzylol
changed the base branch from
732-test-add-prometheus-remote-write-promql-differential-suite
to
refactor/query-plan-dag-execution
September 24, 2026 12:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency stack: main → #768 → #737 → #749 → #771 → #728 → #770 → #763 → #765 → #761 → #742 → #759
Independent follow-ups to #765: #756 (diagnostics), #766 (runtime controls and overhead inspection).
Refs #758. Stacked directly on #765 as an independent tooling PR. It does not depend on #742, and #761/#759 do not depend on it.
Why and behavior
Before this PR: runtime workers followed implicit Tokio defaults, console/file logging could not be disabled independently, and there was no controlled comparison between direct computation, backend execution and HTTP query handling.
After this PR:
--runtime-workers 2 --runtime-max-blocking-threads 8 --log-level off --disable-console-log --disable-file-logcontrols the production runtime and logging while retaining configuration artifacts. A Rust inspection executable scans server workers and client concurrency against direct DDSketch and raw exact median baselines, the real installed-plan query engine, and the real HTTP service. Every layer uses the same deterministic observations; forwarding is disabled and results must agree before measurements count as successful.Reports retain p50/p95/p99 and samples, throughput, failed/dropped requests, process/driver CPU, RSS/peak RSS, observed threads, effective logging and visible cgroup limits. Fixed-rate arrivals include scheduling delay and count overload drops; closed-loop concurrency is also supported. Direct synchronous kernel timing is reported separately from task-dispatch latency. Each matrix cell uses a fresh process, with configurable warmup/repeats and JSON/CSV output.
The developer guide documents the shared runtime/task model, measurement boundaries, log comparisons and profiling commands. CI checks correctness and a small matrix, without imposing performance thresholds on shared runners.
Validation and limits
passed=false.RUST_LOGprecedence is verified.-D warnings, formatting and diff checks pass.Shared physical operator stack update
The shared runtime, operators and sketch codec are owned by ASAPPlanner #462, built on Planner #461. Backend #770 consumes them, #763 integrates ingestion and #765 integrates queries. The stack uses general semi-join and grouped Sort → Limit, with execution phase on the node. Independent library tests run in Planner; deployment acceptance stays in this backend stack.
Scope verification
The reorganized #759 and independent #766 trees pass strict workspace/all-target Clippy. Shared Rust runner tests pass. This does not resolve the existing #754 plan-shape gates or establish live performance benefit.