Skip to content

Fix pre-commit failures on main - #31

Merged
namurphy merged 2 commits into
mainfrom
ci/fix-pre-commit-on-main
Sep 24, 2026
Merged

namurphy merged 2 commits into
mainfrom
ci/fix-pre-commit-on-main

Conversation

@joyvelasquez

Copy link
Copy Markdown
Collaborator

typos and the whitespace/line-ending hooks were failing on the test data added in #23 and #24 (for example, typos flags the PARM mnemonic in the .blk files). The pre-commit.ci autofix also rewrote those data files' line endings.

This PR:

  • Excludes tests/data/ from all pre-commit hooks, since those are original mission files that shouldn't be reformatted or spell-checked
  • Moves a ruff:ignore[PLW2901] in get_layout onto the line it applies to, fixing a ruff-check failure on main

Needed for #30 to pass pre-commit.ci.

@joyvelasquez joyvelasquez self-assigned this Sep 24, 2026
@joyvelasquez joyvelasquez added the enhancement New feature or request label Sep 24, 2026
@joyvelasquez

Copy link
Copy Markdown
Collaborator Author

@namurphy This fixes the pre-commit.ci failures on main from the test data in #23/#24 (typos flagging PARM in the .blk files, and autofix rewriting their line endings). It's needed before #30 can pass. Happy to adjust if you'd prefer a narrower exclude or a different approach for the data files. Things got really messy with running black.

@joyvelasquez joyvelasquez added CI Continuous integration and GitHub Actions and removed enhancement New feature or request labels Sep 24, 2026

@namurphy namurphy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cleaning up after me! I merged a few pull requests a little too quickly, it appears. 😅

Excluding tests/data/ from pre-commit is a good idea since the directory is for sample files from the current pipeline. 👍🏻

@namurphy
namurphy merged commit a215372 into main Sep 24, 2026
11 checks passed
@namurphy
namurphy deleted the ci/fix-pre-commit-on-main branch September 24, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous integration and GitHub Actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants