Skip to content

Add docstrings to pipeline functions - #30

Merged
namurphy merged 23 commits into
mainfrom
docs/add-pipeline-docstrings
Sep 30, 2026
Merged

namurphy merged 23 commits into
mainfrom
docs/add-pipeline-docstrings

Conversation

@joyvelasquez

Copy link
Copy Markdown
Collaborator

This PR adds NumPy-style docstrings to functions in the pipeline modules that currently have none. Each function gets its own commit, so the changes are easy to review one at a time, issue #26 .

@joyvelasquez joyvelasquez self-assigned this Sep 23, 2026
@joyvelasquez joyvelasquez added the documentation Improvements or additions to documentation label Sep 23, 2026
@joyvelasquez

Copy link
Copy Markdown
Collaborator Author

Hey @namurphy , should we address the pdb.set_trace() now in this PR for these two scripts? Figuring out how to address it now as I know we'll see this in most script we add in the near future.

@joyvelasquez

Copy link
Copy Markdown
Collaborator Author

pre-commit.ci autofix

@joyvelasquez joyvelasquez added pipeline: L0 Raw telemetry / L0 processing pipeline: L1 L1 processing (calibrated counts/currents) labels Sep 24, 2026
@joyvelasquez

Copy link
Copy Markdown
Collaborator Author

@namurphy This is ready for review. All checks are passing now that #31 is merged. Added/Updated docstrings to every function in ccsds_reader_pipeline.py and swp_spc_l02l1.py. I also removed the D rule suppressions (D101, D103, D400) that are no longer needed. Once merged we can Closes #26.

Comment on lines +66 to +71

Notes
-----
If the file cannot be read, this function prints the error, opens a
``pdb`` debugging session, and then exits the program.
@namurphy - should we start to replace these ``pdb`` so we don't heavy over use ``ruff:ignore``

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Notes
-----
If the file cannot be read, this function prints the error, opens a
``pdb`` debugging session, and then exits the program.
@namurphy - should we start to replace these ``pdb`` so we don't heavy over use ``ruff:ignore``

Comment thread src/pyfaradaycup/pipeline/ccsds_reader_pipeline.py Outdated
Comment thread src/pyfaradaycup/pipeline/swp_spc_l02l1.py Outdated
Comment thread src/pyfaradaycup/pipeline/swp_spc_l02l1.py
Comment thread src/pyfaradaycup/pipeline/swp_spc_l02l1.py Outdated
joyvelasquez and others added 3 commits September 30, 2026 16:56
Co-authored-by: Nick Murphy <namurphy@users.noreply.github.com>
Co-authored-by: Nick Murphy <namurphy@users.noreply.github.com>
Co-authored-by: Nick Murphy <namurphy@users.noreply.github.com>
@namurphy
namurphy merged commit b0e25f1 into main Sep 30, 2026
11 checks passed
@namurphy
namurphy deleted the docs/add-pipeline-docstrings branch September 30, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation pipeline: L0 Raw telemetry / L0 processing pipeline: L1 L1 processing (calibrated counts/currents)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants