Optimize OutputIterator using a queue structure - #3725
Merged
Astralcircle merged 3 commits intoSep 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced table.insert and table.remove(self, 1) with a queue implementation using explicit first and last pointers, because shifting elements out of a table with table.remove(1) triggers a re-indexing every iteration
I've taken inspiration from here: https://www.lua.org/pil/11.4.html
I've tested implementing this with the following code: gist
Results:

Ignore the push/pop score, i've been making an addon with my own personal wiremod preferences (hence why the gist code looks like that) but i think this change would benefit wiremod