Skip to content

A corrupt remote cache entry can crash vp run #780

Description

@wan9chi

A cache entry stores the task's duration as seconds plus nanoseconds. When decoding an entry, vp run builds the duration without checking those fields, and values that overflow make it panic. Release builds abort on panic, so one corrupt or malicious entry in the remote cache kills the whole run instead of being treated as a miss.

Expected: an entry that doesn't decode is a cache miss, like other corrupt remote entries.

Affects remote cache reads (#756).

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Fields

    Priority

    None yet

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions