Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4518 +/- ##
==========================================
+ Coverage 49.99% 50.00% +0.01%
==========================================
Files 151 151
Lines 29916 29921 +5
==========================================
+ Hits 14956 14962 +6
+ Misses 14960 14959 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
chris-ashe
left a comment
chris-ashe
left a comment
There was a problem hiding this comment.
A few things about understanding of the constraint. Alot of the calcs need to be put into the specific TF configuration class
| ) | ||
|
|
||
|
|
||
| @ConstraintManager.register_constraint(93, "GJ/m3", ">=") |
There was a problem hiding this comment.
Should this not be <= as it places an upper limit on the stored energy to copper ratio?
There was a problem hiding this comment.
Sure, but it is expressed in this constraint as Vol_Cu >= stored energy. I think this is just down to how you want to write the constraint.
| ) | ||
|
|
||
|
|
||
| @ConstraintManager.register_constraint(93, "GJ/m3", ">=") |
There was a problem hiding this comment.
| @ConstraintManager.register_constraint(93, "GJ/m3", ">=") | |
| @ConstraintManager.register_constraint(93, "GJ/m³", ">=") |
| e_tf_magnetic_stored_total_gj: Total stored energy in TF coils (GJ) | ||
| magnetic_stored_energy_copper_vol_ratio: TF coil stored energy to copper volume ratio | ||
| """ | ||
| vol_tf_copper = ( |
There was a problem hiding this comment.
This value is going to be wildly different depending on what type of turn is used. f_a_tf_turn_cable_copper only represents the area fraction of copper in a superconducting strand in CICC configuration.
| """ | ||
| vol_tf_copper = ( | ||
| data.tfcoil.f_a_tf_turn_cable_copper | ||
| * data.superconducting_tfcoil.dr_tf_turn |
There was a problem hiding this comment.
a_tf_turn could just be used here
| "The TF coil WP thickness (dr_tf_wp_with_insulation) must be at least", | ||
| dr_tf_wp_min=dr_tf_wp_min, | ||
| ) | ||
| #if data.numerics.boundl[140] < dr_tf_wp_min: |
There was a problem hiding this comment.
I did comment this out, but I have a suspicion this just wrong. The original code checks agains ixc = 139, which is dx_tf_hts_tape_copper this doesn't match the error message or make sense why it would be checked. Also why check the lower bound? Whereas ixc = 140 is dr_tf_wp_with_insulation.
| I.e. p_l_h_threshold_mw / p_plasma_separatrix_mw >= f_l_mode_margin | ||
| """ | ||
|
|
||
| magnetic_stored_energy_copper_vol_ratio: float = 0.25 |
There was a problem hiding this comment.
I am unsure about the definition of this and it doesn't follow the style guide. Does this mean 0.25 GJ of stored energy per 1 m^3 of copper in the TF coil is the upper limit?
There was a problem hiding this comment.
The otherway the ratio is the copper volume divided by stored energy.
There was a problem hiding this comment.
I tend to try and avoid personalised edits to the .gitignore as this makes it long and confusing
| """ | ||
|
|
||
| magnetic_stored_energy_copper_vol_ratio: float = 0.25 | ||
| """TF coil stored energy to copper volume ratio (`constraint equation 93`) """ |
There was a problem hiding this comment.
Can we comment the units here, even if it is dimensionless [-]
There was a problem hiding this comment.
will add [m3/GJ]
708fe36 to
fb18553
Compare
4 participants
Adds new quench protection metric.