Conversation
roychying
added this pull request to stack #742
September 23, 2026 18:02
roychying
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
September 23, 2026 18:02
roychying
force-pushed
the
chenghan.ying/sq-storage-4-core
branch
from
September 23, 2026 19:10
a125c16 to
0780d1b
Compare
roychying
force-pushed
the
chenghan.ying/sq-storage-4-core
branch
from
September 23, 2026 19:23
0780d1b to
a560bcb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
submitqueue/core/is infra shared between the domain's services, so it should not depend on one. After the split, files there that resolve stores name a service's aggregate (the inversion raised in #740 and #741 ).What?
Moves the packages that serve exactly one service:
core/batch/*orchestrator/core/batchcore/request/{log,terminate}.goorchestrator/core/requestcore/request/{materializer,request}.gogateway/core/requestcore/requestdivides along the publish/persist line: the orchestrator publishes lifecycle events on the log topic, the gateway persists them.core/changesetcould not move for now — seven domain-level extension packages still depend on it. Relocating it would have created a new inversion. Instead it declares the slice of an aggregate itneeds:
No file under submitqueue/core/ imports a service package now.
Test Plan
Issue