Repository navigation
Conversation
T0mstone
approved these changes
Oct 4, 2026
mkorje
reviewed
Oct 7, 2026
Comment on lines
68
to
71
| /// Italic style. May be serif or sans-serif depending on the font. | ||
| /// | ||
| /// Supported characters: latin, greek, dotless, and the extra ħ (U+0127). | ||
| Italic, |
Collaborator
There was a problem hiding this comment.
Could you add the new char to the doc comment here please?
Comment on lines
+498
to
+499
| // Additional Latin symbol (U+1D6A6) | ||
| '' => -0x8EF, |
Collaborator
There was a problem hiding this comment.
The comments I had here matched the bold header from the Unicode chart, so Ligature long s (U+1D6A6) I'd prefer.
| 'Γ' => 0x1DAB, | ||
| 'Π' => 0x1D9F, | ||
| // Double-struck large operator (U+2140) | ||
| '∑' => return '⅀', // delta is negative |
Collaborator
There was a problem hiding this comment.
Not entirely related to this PR, but since you've made the change to allow negative deltas, we should change this too then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for styling a new Latin letter that was added in Unicode 18.0. The plain letter is U+1DF95, from Latin Extended-G, and the mathematical italic form is U+1D6A6, from Mathematical Alphanumeric Symbols.
The first commit bumps the MSRV to 1.92 (same as Typst), which is necessary to use
u32::strict_add_signedto support the negative delta.This was tested with the following assertions: