Keep duplicated ports on finite shared region edges - #196
Draft
AnasSarkiz wants to merge 2 commits into
Draft
AnasSarkiz wants to merge 2 commits into
AnasSarkiz wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Benchmark This PRRun benchmarks by commenting on this PR: Everything after Examples:
Any PR whose title contains |
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duplicating a congested port between offset rectangles used a direction perpendicular to their centers. That direction can leave the shared edge, and an offset near its endpoint can leave the finite boundary entirely.
Compute the shared edge from the intersection of the region bounds and place duplicates along its available length. This preserves both region membership and distinct port positions without changing routing thresholds.
Before / after
Actual output from the regression test on main
7745c91and this branch; the gray line marks the shared edge.Validation
Extracted as an independent fix from #193. This PR does not claim to resolve all SRJ18 Pipeline 9 failures; downstream DRC and same-machine benchmark validation remain necessary.