fix: Keep congested-port duplicates on their shared boundary - #191
Open
AnasSarkiz wants to merge 1 commit into
Open
AnasSarkiz wants to merge 1 commit into
AnasSarkiz wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Benchmark This PRRun benchmarks by commenting on this PR: Everything after Examples:
Any PR whose title contains |
AnasSarkiz
force-pushed
the
fix/greedy-final-route-hard-constraints
branch
from
September 15, 2026 16:09
ea8202e to
9b61d75
Compare
AnasSarkiz
force-pushed
the
fix/greedy-final-route-hard-constraints
branch
from
September 15, 2026 17:57
9b61d75 to
b0481ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: not ready to merge
The geometry-only candidate has downstream regressions. Of five focused autorouter tests, preloaded duplication and Sample006 pass; pedometer low effort completes routing but fails its SVG snapshot (21.740% difference), bugreport77 completes routing but has 98 relaxed-DRC errors (requires fewer than 94), and pedometer high density fails. Current autorouter main with its existing tiny-hypergraph pin passes bugreport77 unchanged using the same installed dependencies, confirming that DRC failure is a regression. Existing assertions and snapshots have not been changed. Keep the current merged pin while this candidate is unresolved; additional diagnostics are stopped.
Problem and fix
An isolated port shared by two rectangular regions is duplicated using a perpendicular between their centers. When the centers are offset, that direction leaves the shared edge. Reversing the incident regions can also reverse the duplicate direction, and short edges can be overrun by the fixed offset span.
Place these duplicates along the actual shared rectangle edge with a direction independent of incident-region order. Preserve the source coordinate perpendicular to the edge, reverse at the positive endpoint, and bound the group's span so the duplicates remain distinct and within the edge. Existing nearest-port and generic-geometry behavior is preserved.
The PR changes only duplicate placement and its regression tests.
lib/core.tsand its single-layer cost tests match main exactly. The existing greedy completion behavior is preserved.Validation
7745c91a426a64227eb9b4a3e2c093c24b9f9808, preserving the latest fix already pinned in autorouter main.Geometry-only candidate:
b0481ce866f581c2fd81d2a0ec24bfda1d31d538. Exact downstream validation is recorded in tscircuit/tscircuit-autorouter#2586. Benchmarks remain with the requester.