Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
0375746
feat(run-engine): concurrency-key virtual-time key builders
1stvamp Jul 23, 2026
91fb435
feat(run-engine): ckVirtualTimeScheduling options flag
1stvamp Jul 23, 2026
3591bea
feat(run-engine): two-pass virtual-time CK dequeue command
1stvamp Jul 24, 2026
113904f
feat(run-engine): register CK variants in vtime index on enqueue
1stvamp Jul 24, 2026
1765b77
feat(run-engine): re-register CK variants in vtime index on nack
1stvamp Jul 24, 2026
f646766
test(run-engine): fairness scenarios on the real batched dequeue path
1stvamp Jul 24, 2026
9dac71b
test(run-engine): multi-consumer correctness + op-count budget
1stvamp Jul 24, 2026
24b6220
test(run-engine): default-off regression proof
1stvamp Jul 24, 2026
bddc82e
feat(run-engine,webapp): wire ckVirtualTimeScheduling env flag (code-…
1stvamp Jul 24, 2026
86977ff
chore(run-engine): ship note + comment/format cleanup
1stvamp Jul 24, 2026
2b1c389
fix(run-engine,webapp): address whole-branch adversarial review
1stvamp Jul 24, 2026
5cb0aa5
docs(run-engine): record CK vtime known limitations for GA decision
1stvamp Jul 24, 2026
e9da64c
docs(run-engine): plan + references for virtual-time CK fair scheduling
1stvamp Jul 23, 2026
dce0b72
docs(run-engine): add fairness explainer diagrams
1stvamp Jul 24, 2026
21211ae
fix(run-engine): move design docs out of the Mintlify docs/ tree; format
1stvamp Jul 24, 2026
e1444eb
docs(run-engine): tighten CK fairness server-changes note
1stvamp Jul 24, 2026
dea03c6
docs(run-engine): fix stale references in the CK fairness design docs
1stvamp Jul 26, 2026
c804278
docs(run-engine): add CK virtual-time A/B benchmark plan and harness
1stvamp Jul 27, 2026
da3c8fb
docs(run-engine): make the e2e bench harness work on self-hosted
1stvamp Jul 27, 2026
4994295
docs(run-engine): add CK virtual-time benchmark results
1stvamp Jul 27, 2026
3dd789f
chore(run-engine): gitignore benchmark output artifacts
1stvamp Jul 27, 2026
31606d3
docs(run-engine): benchmark Redis CPU and memory vs concurrency-key c…
1stvamp Jul 28, 2026
9015810
chore(run-engine): drop benchmark, e2e, and design docs from the branch
1stvamp Jul 28, 2026
bb07b0b
fix(run-engine): stop an unservable variant pinning the ck virtual-ti…
1stvamp Jul 31, 2026
819e021
fix(run-engine): advance the ck virtual-time floor from servable vari…
1stvamp Jul 31, 2026
b932442
fix(run-engine): keep unservable ck variants in the fair order
1stvamp Jul 31, 2026
d8c5201
fix(run-engine): make ck vtime pass 2 discover unregistered variants
1stvamp Aug 3, 2026
f538f8d
test(run-engine): bound the ckManyKeys first-serve claim
1stvamp Aug 3, 2026
5cd0c65
test(run-engine): pin the ck vtime window-freeze and stranded-entry b…
1stvamp Aug 6, 2026
c2fd2be
docs(run-engine): note the ck vtime retry-storm fallback in the relea…
1stvamp Aug 6, 2026
3298ee2
fix(run-engine): stop unready ck variants blocking the fair pass, and…
1stvamp Aug 15, 2026
6ce9d2a
fix(run-engine): guard the wildcard cleanup in the ck vtime scripts
1stvamp Aug 15, 2026
701d164
fix(run-engine): register a gated ck variant so it can rejoin the fai…
1stvamp Aug 16, 2026
d21cbb9
fix(run-engine): drop drained ck variants from the fair order on ack,…
1stvamp Aug 17, 2026
af407f5
fix(run-engine): remember a drained ck variant's virtual time
1stvamp Aug 18, 2026
50351eb
fix(run-engine): bound the ck idle set by rank, not just by floor
1stvamp Aug 18, 2026
dca1e9c
perf(run-engine): cut two Redis calls from the ck vtime registration …
1stvamp Aug 19, 2026
2b6bfee
perf(run-engine): stop re-registering ck variants already in the fair…
1stvamp Aug 19, 2026
f5c1d74
fix(run-engine): keep the ck vtime floor alive alongside the tags it …
1stvamp Aug 19, 2026
d018b28
docs(run-engine): cut the ck fair scheduling release note down to the…
1stvamp Aug 19, 2026
c11b5c8
fix(run-engine): register a brand-new ck variant behind the pack, not…
1stvamp Aug 20, 2026
bb4d67d
test(run-engine): pin the fresh-key fix and isolate the ck idle rank cap
1stvamp Aug 20, 2026
f3ad8d6
fix(run-engine): stop the ck arrival cap from being reachable
1stvamp Aug 20, 2026
64b2fc9
fix(run-engine): stop concurrency-gated ck variants eating the fair pass
1stvamp Aug 21, 2026
e8aa263
test(run-engine): cover the future-head window guard a mutation audit…
1stvamp Aug 21, 2026
18e6dce
test(run-engine): pin the ck vtime credit round trip and TTL registra…
1stvamp Aug 21, 2026
0a9998d
fix(run-engine): stop the gated ck batch rewinding a live virtual-tim…
1stvamp Aug 21, 2026
2b7a533
test(run-engine): pin the parked tag a gated variant registers with
1stvamp Aug 21, 2026
88127be
docs(run-engine): cut the ck vtime comments back to what the code can…
1stvamp Aug 21, 2026
3c23a3a
fix(run-engine): re-register the TTL entry when the vtime dequeue exp…
1stvamp Aug 21, 2026
e69f000
fix(run-engine): keep parked ck credit when pass 2 repairs a variant
1stvamp Sep 7, 2026
a5fa891
refactor(run-engine): share one copy of the ck ack, nack and dead-let…
1stvamp Sep 15, 2026
838896a
fix(run-engine): restore the snapshotRoute read in the vtime TTL sweep
1stvamp Sep 15, 2026
0584290
refactor(run-engine): share one copy of the remaining ck lua
1stvamp Sep 15, 2026
c5c6bc9
fix(run-engine): make a mistyped ck lua slot a compile error
1stvamp Sep 15, 2026
c8872e2
test(run-engine): pin the snapshotRoute the vtime TTL sweep hands the…
1stvamp Sep 15, 2026
43d0722
test(run-engine): load every run-queue script into redis
1stvamp Sep 15, 2026
565ad2c
merge: integrate origin/main into ck virtual-time scheduling
1stvamp Sep 18, 2026
c4b657d
test(run-engine): thread groupConcurrencyKey into the two direct-Lua …
1stvamp Sep 19, 2026
c4af9aa
docs(run-engine): correct the ckExpireTtlLua sharing comment
1stvamp Sep 19, 2026
b02f4f0
feat(run-engine): warn when ck vtime and queue-gates are both enabled
1stvamp Sep 19, 2026
a9a14be
feat(run-engine): enforce queue-gates in the vtime dequeue and TTL sweep
1stvamp Sep 19, 2026
9040133
feat(webapp): allow a fractional ck vtime quantum
1stvamp Sep 19, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .server-changes/2026-07-24-ck-fair-scheduling.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
area: webapp
type: feature
---

One concurrency key with a large backlog no longer holds up runs waiting on other keys on the same queue.
10 changes: 10 additions & 0 deletions apps/webapp/app/env.server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1221,6 +1221,16 @@ const EnvironmentSchema = z
RUN_ENGINE_TTL_CONSUMERS_DISABLED: BoolEnv.default(false),
RUN_ENGINE_TTL_WORKER_BATCH_MAX_WAIT_MS: z.coerce.number().int().default(5_000),

// Fair (virtual-time) ordering across concurrency-key variants of a base queue.
// Off by default; when off the run queue behaves exactly as before.
RUN_ENGINE_CK_VTIME_SCHEDULING_ENABLED: BoolEnv.default(false),
// Fractional allowed: the vtime Lua serves weighted fair-queue tags, so a sub-1 quantum
// is a valid finer serve granularity. The weight hook is fixed at 1 today, so 1 stays the
// default, but the schema no longer blocks the capability the engine already has.
RUN_ENGINE_CK_VTIME_QUANTUM: z.coerce.number().positive().default(1),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Infinite quantum freezes fair scheduling

RUN_ENGINE_CK_VTIME_QUANTUM=Infinity passes validation and assigns infinite tags after each variant's first serve. Those tags never advance, so subsequent ties resolve lexically and fair scheduling collapses.

Learn more

Zod's positive-number check accepts positive infinity. The value flows through RunQueue unchanged and Lua adds it to each served variant's virtual-time score. Once scores become infinite, adding another quantum cannot distinguish service history, so the sorted set falls back to lexical tie-breaking.

Example: Setting the environment variable to Infinity or 1e309 starts successfully. After variants a and b each run once, both carry infinite scores; repeated dequeues choose by queue name rather than alternating by consumed service.

Recommended fix: Add .finite() to this schema before accepting the quantum. Keep fractional finite values valid.

Suggested change
RUN_ENGINE_CK_VTIME_QUANTUM: z.coerce.number().positive().default(1),
RUN_ENGINE_CK_VTIME_QUANTUM: z.coerce.number().finite().positive().default(1),

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

RUN_ENGINE_CK_VTIME_WINDOW_MULTIPLIER: z.coerce.number().int().positive().default(3),
RUN_ENGINE_CK_VTIME_STATE_TTL_SECONDS: z.coerce.number().int().positive().default(86400),

/** Optional maximum TTL for all runs (e.g. "14d"). If set, runs without an explicit TTL
* will use this as their TTL, and runs with a TTL larger than this will be clamped. */
RUN_ENGINE_DEFAULT_MAX_TTL: z.string().optional(),
Expand Down
8 changes: 8 additions & 0 deletions apps/webapp/app/v3/runEngine.server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,14 @@ function createRunEngine() {
batchMaxSize: env.RUN_ENGINE_TTL_WORKER_BATCH_MAX_SIZE,
batchMaxWaitMs: env.RUN_ENGINE_TTL_WORKER_BATCH_MAX_WAIT_MS,
},
ckVirtualTimeScheduling: env.RUN_ENGINE_CK_VTIME_SCHEDULING_ENABLED
? {
enabled: true,
quantum: env.RUN_ENGINE_CK_VTIME_QUANTUM,
scanWindowMultiplier: env.RUN_ENGINE_CK_VTIME_WINDOW_MULTIPLIER,
stateTtlSeconds: env.RUN_ENGINE_CK_VTIME_STATE_TTL_SECONDS,
}
: undefined,
},
runLock: {
redis: {
Expand Down
1 change: 1 addition & 0 deletions internal-packages/run-engine/src/engine/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@ export class RunEngine {
workerItemsSuffix: "ttl-worker:{queue:ttl-expiration:}items",
visibilityTimeoutMs: options.queue?.ttlSystem?.visibilityTimeoutMs ?? 30_000,
},
ckVirtualTimeScheduling: options.queue?.ckVirtualTimeScheduling,
});

this.worker = new Worker({
Expand Down
5 changes: 4 additions & 1 deletion internal-packages/run-engine/src/engine/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import {
} from "@trigger.dev/redis-worker";
import type { ControlPlaneResolver } from "./controlPlaneResolver.js";
import type { FairQueueSelectionStrategyOptions } from "../run-queue/fairQueueSelectionStrategy.js";
import type { RunQueueMetricsEmitter } from "../run-queue/index.js";
import type { RunQueueMetricsEmitter, RunQueueOptions } from "../run-queue/index.js";
import type { MinimalAuthenticatedEnvironment } from "../shared/index.js";
import type { LockRetryConfig } from "./locking.js";
import type { workerCatalog } from "./workerCatalog.js";
Expand Down Expand Up @@ -131,6 +131,9 @@ export type RunEngineOptions = {
/** Max time (ms) to wait for more items before flushing a batch (default: 5000) */
batchMaxWaitMs?: number;
};
/** Fair (virtual-time) ordering across concurrency-key variants of a base queue.
* Passed through to RunQueue; off by default (undefined = today's behaviour). */
ckVirtualTimeScheduling?: RunQueueOptions["ckVirtualTimeScheduling"];
};
runLock: {
redis: RedisOptions;
Expand Down
Loading
Loading