-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(run-engine): fair virtual-time scheduling for the concurrency-key dequeue #4367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
1stvamp
wants to merge
63
commits into
main
Choose a base branch
from
feat/ck-virtual-time-scheduling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
0375746
feat(run-engine): concurrency-key virtual-time key builders
1stvamp 91fb435
feat(run-engine): ckVirtualTimeScheduling options flag
1stvamp 3591bea
feat(run-engine): two-pass virtual-time CK dequeue command
1stvamp 113904f
feat(run-engine): register CK variants in vtime index on enqueue
1stvamp 1765b77
feat(run-engine): re-register CK variants in vtime index on nack
1stvamp f646766
test(run-engine): fairness scenarios on the real batched dequeue path
1stvamp 9dac71b
test(run-engine): multi-consumer correctness + op-count budget
1stvamp 24b6220
test(run-engine): default-off regression proof
1stvamp bddc82e
feat(run-engine,webapp): wire ckVirtualTimeScheduling env flag (code-…
1stvamp 86977ff
chore(run-engine): ship note + comment/format cleanup
1stvamp 2b1c389
fix(run-engine,webapp): address whole-branch adversarial review
1stvamp 5cb0aa5
docs(run-engine): record CK vtime known limitations for GA decision
1stvamp e9da64c
docs(run-engine): plan + references for virtual-time CK fair scheduling
1stvamp dce0b72
docs(run-engine): add fairness explainer diagrams
1stvamp 21211ae
fix(run-engine): move design docs out of the Mintlify docs/ tree; format
1stvamp e1444eb
docs(run-engine): tighten CK fairness server-changes note
1stvamp dea03c6
docs(run-engine): fix stale references in the CK fairness design docs
1stvamp c804278
docs(run-engine): add CK virtual-time A/B benchmark plan and harness
1stvamp da3c8fb
docs(run-engine): make the e2e bench harness work on self-hosted
1stvamp 4994295
docs(run-engine): add CK virtual-time benchmark results
1stvamp 3dd789f
chore(run-engine): gitignore benchmark output artifacts
1stvamp 31606d3
docs(run-engine): benchmark Redis CPU and memory vs concurrency-key c…
1stvamp 9015810
chore(run-engine): drop benchmark, e2e, and design docs from the branch
1stvamp bb07b0b
fix(run-engine): stop an unservable variant pinning the ck virtual-ti…
1stvamp 819e021
fix(run-engine): advance the ck virtual-time floor from servable vari…
1stvamp b932442
fix(run-engine): keep unservable ck variants in the fair order
1stvamp d8c5201
fix(run-engine): make ck vtime pass 2 discover unregistered variants
1stvamp f538f8d
test(run-engine): bound the ckManyKeys first-serve claim
1stvamp 5cd0c65
test(run-engine): pin the ck vtime window-freeze and stranded-entry b…
1stvamp c2fd2be
docs(run-engine): note the ck vtime retry-storm fallback in the relea…
1stvamp 3298ee2
fix(run-engine): stop unready ck variants blocking the fair pass, and…
1stvamp 6ce9d2a
fix(run-engine): guard the wildcard cleanup in the ck vtime scripts
1stvamp 701d164
fix(run-engine): register a gated ck variant so it can rejoin the fai…
1stvamp d21cbb9
fix(run-engine): drop drained ck variants from the fair order on ack,…
1stvamp af407f5
fix(run-engine): remember a drained ck variant's virtual time
1stvamp 50351eb
fix(run-engine): bound the ck idle set by rank, not just by floor
1stvamp dca1e9c
perf(run-engine): cut two Redis calls from the ck vtime registration …
1stvamp 2b6bfee
perf(run-engine): stop re-registering ck variants already in the fair…
1stvamp f5c1d74
fix(run-engine): keep the ck vtime floor alive alongside the tags it …
1stvamp d018b28
docs(run-engine): cut the ck fair scheduling release note down to the…
1stvamp c11b5c8
fix(run-engine): register a brand-new ck variant behind the pack, not…
1stvamp bb4d67d
test(run-engine): pin the fresh-key fix and isolate the ck idle rank cap
1stvamp f3ad8d6
fix(run-engine): stop the ck arrival cap from being reachable
1stvamp 64b2fc9
fix(run-engine): stop concurrency-gated ck variants eating the fair pass
1stvamp e8aa263
test(run-engine): cover the future-head window guard a mutation audit…
1stvamp 18e6dce
test(run-engine): pin the ck vtime credit round trip and TTL registra…
1stvamp 0a9998d
fix(run-engine): stop the gated ck batch rewinding a live virtual-tim…
1stvamp 2b7a533
test(run-engine): pin the parked tag a gated variant registers with
1stvamp 88127be
docs(run-engine): cut the ck vtime comments back to what the code can…
1stvamp 3c23a3a
fix(run-engine): re-register the TTL entry when the vtime dequeue exp…
1stvamp e69f000
fix(run-engine): keep parked ck credit when pass 2 repairs a variant
1stvamp a5fa891
refactor(run-engine): share one copy of the ck ack, nack and dead-let…
1stvamp 838896a
fix(run-engine): restore the snapshotRoute read in the vtime TTL sweep
1stvamp 0584290
refactor(run-engine): share one copy of the remaining ck lua
1stvamp c5c6bc9
fix(run-engine): make a mistyped ck lua slot a compile error
1stvamp c8872e2
test(run-engine): pin the snapshotRoute the vtime TTL sweep hands the…
1stvamp 43d0722
test(run-engine): load every run-queue script into redis
1stvamp 565ad2c
merge: integrate origin/main into ck virtual-time scheduling
1stvamp c4b657d
test(run-engine): thread groupConcurrencyKey into the two direct-Lua …
1stvamp c4af9aa
docs(run-engine): correct the ckExpireTtlLua sharing comment
1stvamp b02f4f0
feat(run-engine): warn when ck vtime and queue-gates are both enabled
1stvamp a9a14be
feat(run-engine): enforce queue-gates in the vtime dequeue and TTL sweep
1stvamp 9040133
feat(webapp): allow a fractional ck vtime quantum
1stvamp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| area: webapp | ||
| type: feature | ||
| --- | ||
|
|
||
| One concurrency key with a large backlog no longer holds up runs waiting on other keys on the same queue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Infinite quantum freezes fair scheduling
RUN_ENGINE_CK_VTIME_QUANTUM=Infinitypasses validation and assigns infinite tags after each variant's first serve. Those tags never advance, so subsequent ties resolve lexically and fair scheduling collapses.Learn more
Zod's positive-number check accepts positive infinity. The value flows through
RunQueueunchanged and Lua adds it to each served variant's virtual-time score. Once scores become infinite, adding another quantum cannot distinguish service history, so the sorted set falls back to lexical tie-breaking.Example: Setting the environment variable to
Infinityor1e309starts successfully. After variantsaandbeach run once, both carry infinite scores; repeated dequeues choose by queue name rather than alternating by consumed service.Recommended fix: Add
.finite()to this schema before accepting the quantum. Keep fractional finite values valid.Was this helpful? React with 👍 or 👎 to provide feedback.