Repository navigation
PM-6530 Use in-app submission deletion confirmation -> dev - #2443
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket
https://topcoder.atlassian.net/browse/PM-6530
What's in this PR?
Replace the browser-native prompt for deleting a Design submission with the shared in-app confirmation modal, showing the selected submission ID and irreversible-action warning. Cancel, Close, and Escape preserve the submission; pending deletion blocks dismissal and duplicate requests, and failures leave confirmation available for retry.
Retains phase restrictions, submission replacement, count refreshes, and unregister eligibility. Tests exercise the real confirmation modal, including its Escape callback during an active request, and the opportunities documentation describes the flow.
Validation
yarn lintpassed.NODE_OPTIONS=--max-old-space-size=8192 yarn run buildpassed.