module: mixer: rework module to use sink/source api - #11222
Open
softwarecki wants to merge 1 commit into
Open
softwarecki wants to merge 1 commit into
softwarecki wants to merge 1 commit into
Conversation
Rework the mixer module to only use the sink/source api to prepare sof for the full transition to pipeline 2.0. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
softwarecki
requested review from
abonislawski,
piotrhoppeintel,
serhiy-katsyuba-intel,
tmleman and
wjablon1
and
a lite review from Copilot
September 22, 2026 15:50
softwarecki
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
September 22, 2026 15:50
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Use the sink accessor for the sink alignment calculation instead of passing a sink handle to source_get_channels().
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Reworks the mixer module to use sink/source APIs for the Pipeline 2.0 transition.
Changes:
- Migrates processing to circular-buffer descriptors.
- Updates generic and HiFi mixer implementations.
- Adapts mixer interfaces and unit tests.
| File | Summary |
|---|---|
test/cmocka/src/audio/mixer/mixer_test.c |
Updates mixer tests for circular-buffer descriptors. |
src/audio/mixer/mixer.h |
Defines the new mixer callback interface. |
src/audio/mixer/mixer.c |
Migrates mixer lifecycle and processing logic; moderate issue (3 votes) with passing a sink handle to source_get_channels(). |
src/audio/mixer/mixer_hifi3.c |
Updates optimized HiFi mixing implementations. |
src/audio/mixer/mixer_generic.c |
Updates generic mixing implementations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| static void mixer_set_sink_frame_alignment(struct sof_sink *snk) | ||
| { | ||
| const uint32_t byte_align = mixer_get_byte_align(source_get_channels(snk)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework the mixer module to only use the sink/source api to prepare sof for the full transition to pipeline 2.0.