docs(iterate-pr): describe the OpenSpec label and tip warning - #383
Conversation
|
@claude /review |
|
Claude finished @thecodedrift's task in 2m 14s —— View job Review mode: incremental — read 0 prior review thread(s) before reviewing.
ScopeThis is a docs-only change: What I checkedI read the new prose against the actual workflow YAML (
FindingOne inline comment posted:
No other correctness issues found; the rest of the rewritten section checks out against the workflows it describes. |
The section predated openspec-label.yml, openspec-tracking.yml and openspec-sweep.yml and told an agent that nothing reports on an unarchived change. It now describes the label predicate, how the tip warning is decided and where it is emitted, what to do on a tip PR versus a non-tip PR, and why 'archive on landing' is not available.
40ad8e7 to
6818039
Compare
The section said openspec-sweep.yml escalates daily once a change directory has gone seven days without git activity. The cron is daily, but openspec-tracking.cjs throttles on the issue's own idle time (idleDays < staleDays continues), so an escalation lands at most once per seven-day window and any comment on the thread defers the next one.
The one finding was real: the sweep cron is daily but — AI Coding Agent |
.agents/skills/iterate-pr/SKILL.mdsaid "there is no gate for it, in either direction" and "nothing will fail either way". That was written beforeopenspec-label.yml,openspec-tracking.ymlandopenspec-sweep.ymlexisted, and an agent on the tip of a stack read it as permission to defer archiving to "on landing".mainonly takes PRs, so a change that lands unarchived needs another PR to correct it: ontaskless/marketing, #50 and #51 landed unarchived and #52 was the correction.The section is rewritten from the workflows themselves:
openspec-label.ymlreads the head tree for any directory underopenspec/changes/other thanarchive/, asks nothing about stack position, appliesOpen OpenSpec);gh pr list --state open --base <this branch>returning zero) and what it emits, a::warning::annotation plus a job-summary block ofpnpm openspec archive <change>lines, not a PR comment;openspec-tracking.yml'sOpenSpec: <change> is unarchived on mainissue withopenspec-sweep.ymlescalating on it after seven days without git activity.One correction to the issue's summary: the tip signal is a workflow annotation and step summary, not a comment posted on the PR. The rewritten section says so, since waiting for a comment that never arrives is the same trap in a new place.
No changeset: the skill ships through dotagents from this repo, not in the
@taskless/clipackage, so it carries no CLI release note.pnpm lint(includingpnpm cli check) andpnpm typecheckpass. The skill's bundledscripts/*.cjsand their tests mention neither OpenSpec nor archiving, so nothing there needed changing.Fixes #375
@claude /review