Skip to content

Multigrid with 3D implicit line agglomeration - #2863

Merged
bigfooted merged 114 commits into
developfrom
feature_fullmg
Sep 23, 2026
Merged

bigfooted merged 114 commits into
developfrom
feature_fullmg

Conversation

@bigfooted

@bigfooted bigfooted commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

Proposed Changes

fix implicit line agglomeration

When MG_IMPLICIT_LINE_AGGLOMERATION=YES, we try to create structured coarser meshes by first agglomerating the boundary, then use a paving method, also known as an advancing front method. We advance the entire front layer by layer, so all viscous walls advance one layer at a time, until the end, until an edge direction deviates more than 30 degrees or until a collision. When paving for a single cell fails, paving for the entire marker stops.

After agglomeration of the viscous walls, the other boundaries are agglomerated in a structured way if their first cell aspect ratio is higher than 2. For structured quadrilateral meshes with inflation layers this method leads to very high quality multigrids.
With MPI, the layers try to continue through the mpi interface. When the mpi interface created by parmetis is not very 'straight', this method often terminates and quality deteriorates. However, even the fallback to regular agglomeration still leads to high quality meshes.

Related Work

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Comment thread SU2_CFD/src/integration/CMultiGridIntegration.cpp Outdated
Comment thread Common/src/geometry/CMultiGridGeometry.cpp Fixed
Comment thread Common/src/geometry/CMultiGridGeometry.cpp Fixed
bigfooted and others added 2 commits August 5, 2026 22:22
… type with wide type in loop condition'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Comment thread TestCases/hybrid_regression.py Fixed
Comment thread TestCases/parallel_regression.py Fixed
Comment thread TestCases/serial_regression.py Fixed
@bigfooted
bigfooted merged commit edbda6e into develop Sep 23, 2026
37 of 38 checks passed
@bigfooted
bigfooted deleted the feature_fullmg branch September 23, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants