Conversation
Signed-off-by: Sanskarzz <sanskar.gur@gmail.com>
Sanskarzz
requested review from
ChrisJBurns,
JAORMX,
amirejaz,
aponcedeleonch,
blkt,
jerm-dro,
jhrozek,
rdimitrov,
reyortiz3 and
tgrunnagle
as code owners
September 30, 2026 14:29
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6731 +/- ##
=======================================
Coverage 79.28% 79.28%
=======================================
Files 802 804 +2
Lines 81218 81271 +53
=======================================
+ Hits 64395 64439 +44
- Misses 16818 16827 +9
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redis session storage configuration currently cannot enable TLS, even though the shared
redisconnlibrary supports it. This prevents standalone vMCP and proxy runtimes from connecting to Redis endpoints that require TLS. Redis-backed rate limiting creates a separate client and needs the same settings.tlsis omitted;tls: {}enables certificate and hostname verification using system roots.redisconn.NewClientfor the rate limiter and share CA loading with the embedded auth server while preserving its existing snake_case configuration.Partially addresses #6730. This is the runtime prerequisite; the Kubernetes API fields, CA Secret projection, and rollout handling will follow in PR B. Keep the issue open until that integration is merged.
TLS support for the operator-wide
defaultRedisfallback is outside the scope of both PR A and PR B and will be tracked in a separate follow-up issue.Type of change
Test plan
task sdk-test).task lint-fix, previously run on the complete implementation).task operator-manifests,task crdref-gen --force) against PR A alone and compare with the staged artifacts.task test-e2e).Coverage includes:
The full repository unit run previously hit a failure in
TestPush/key_push_forwards_signing_capabilityin the plugin client package; that package passed on an isolated rerun. The full repository suite is not claimed as green here. Runner coverage does not execute the fullRunner.Runlifecycle against TLS Redis, and no live Kubernetes workload connection is included in this PR.API Compatibility
v1beta1API.The optional nested
VirtualMCPServer.spec.config.sessionStorage.tlsschema additions are generated from the embedded runtime configuration, in both served versions. They keep generated artifacts aligned with the runtime type; top-levelspec.sessionStorage.tlsand Secret references belong to PR B. Existing omitted TLS settings preserve plaintext behavior.Changes
pkg/redisconfig/tls.gopkg/authserver/runner/embeddedauthserver.gopkg/vmcp/config/config.go,validator.gopkg/vmcp/server/server.gopkg/runner/config.go,runner.go,middleware.gopkg/ratelimit/middleware.gopkg/vmcp/ratelimit/factory/limiter.gotest/helpers/redistls/redistls.gocmd/vmcp/README.mddocs/server/*,sdk/go/openapi.*,sdk/go/client/oas_*_gen.go,sdk/go/client/client_test.goDoes this introduce a user-facing change?
Yes. Standalone
thv vmcp serve --config ...andvmcp serve --config ...accept:For a private CA, set
tls.caCertFileto a readable PEM bundle in the runtime filesystem. Proxy run configurations receive the same optional TLS object under their existing session Redis settings. No new CLI flag is introduced.Implementation plan
Implementation plan
Special notes for reviewers
insecureSkipVerifyis an explicit opt-in that disables certificate and hostname verification.defaultRedisfallback is a separate follow-up.