#3166 fix: allow sqlc.arg/@name to fill gaps in numbered placeholder sequences - #4622
Open
nikolayk812 wants to merge 2 commits into
Open
nikolayk812 wants to merge 2 commits into
nikolayk812 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Mixing sqlc.arg()/@name with explicit $N placeholders fails when the named construct occupies a lower-numbered position than the native placeholders:
-- fails with: could not determine data type of parameter $1
INSERT INTO users (a, b, c) VALUES (sqlc.arg(a), $2, $3);
The mirror case (named construct at the end) worked fine:
-- works
INSERT INTO users (a, b, c) VALUES ($1, $2, sqlc.arg(c));
This asymmetry was reported in #3166.
Root cause
validatePlaceholdersran before number() assigned numbers to sqlc.arg/@name/sqlc.slice occurrences. The gap check only considered native $N placeholders, so it saw {2, 3}, found a gap at 1, and fired the error — not knowing that sqlc.arg(a) was about to fill it.#3166
e2e changes: sqlc.arg(named) now gets numbered before validation runs, so it fills $2 and the first real gap shifts from $2 to $3.