Conversation
Co-authored-by: linear-code[bot] <222613912+linear-code[bot]@users.noreply.github.com>
Co-authored-by: linear-code[bot] <222613912+linear-code[bot]@users.noreply.github.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Contributor
Author
|
Closing in favor of the Cursor cloud agent PR #1679 for SOU-2308. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require authentication for streaming and blocking Ask requests when
EXPERIMENT_ASK_GH_ENABLED=true, returning HTTP 401 before entitlement checks or generation. The blocking gate lives inaskCodebase, covering MCP callers too; existing anonymous access behavior is preserved when AskGH is disabled.Verified with eight endpoint regression cases covering authenticated/anonymous requests with AskGH enabled/disabled, plus targeted ESLint.
Summary by cubic
When
EXPERIMENT_ASK_GH_ENABLEDis enabled, streaming and blocking Ask requests now require authentication and return HTTP 401 before entitlement checks or generation.askCodebase, which also covers the MCPask_codebasetool and the/api/chat/blockingroute.Written for commit 690d684. Summary will update on new commits.