Skip to content

improvement(ui): use chips for table filter actions - #8088

Merged
waleedlatif1 merged 1 commit into
codex/emcn-consolidationfrom
codex/control-fix-table-filter-actions
Sep 21, 2026
Merged

waleedlatif1 merged 1 commit into
codex/emcn-consolidationfrom
codex/control-fix-table-filter-actions

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Use existing Chip treatments for Add filter, Clear filters and Apply filter.
  • Keep automatic and manual filtering behavior; adopt shared 30px geometry, typography and icon spacing.

Type of Change

  • Refactor / maintainability improvement

Testing

  • Full workspace type checks, lint, repository audits (including import and API validation), generators and docs checks pass.
  • Complete EMCN suite and relevant existing consumer tests pass.
  • Isolated browser fixtures cover light/dark, narrow layouts and the affected controls; picker checks cover keyboard selection, search, editable overlays, multiple selection, modal Escape and focus restoration.
  • No landing-page changes or audit tooling included.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@vercel

vercel Bot commented Sep 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 21, 2026 1:58am UTC

Request Review

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the UI migration preserves action behavior and complies with the repository’s shared-component conventions.

Summary

This PR replaces the table filter’s Add, Clear, and Apply action Buttons with canonical Chip controls while retaining the existing filtering handlers and conditional behavior.

  • Uses shared Chip geometry, typography, icon spacing, and visual variants.
  • Preserves native button semantics and automatic/manual filtering behavior.

Reviews (2) · Last reviewed commit: "improvement(ui): use chips for table fil..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the codex/control-fix-table-filter-actions branch from 49f80a2 to 8b02bce Compare September 21, 2026 01:58
@BillLeoutsakosvl346
BillLeoutsakosvl346 changed the base branch from staging to codex/emcn-consolidation September 21, 2026 01:58
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 4881f6e into codex/emcn-consolidation Sep 21, 2026
40 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/control-fix-table-filter-actions branch September 21, 2026 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants