Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
export { KnowledgeFilterHeading } from '@/app/workspace/[workspaceId]/knowledge/components/knowledge-filter-heading'
export { CreateBaseModal } from './create-base-modal'
export { DeleteKnowledgeBaseModal } from './delete-knowledge-base-modal'
export { EditKnowledgeBaseModal } from './edit-knowledge-base-modal'
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import { Button } from '@sim/emcn'
import { FILTER_SECTION_LABEL_CLASS } from '@/app/workspace/[workspaceId]/components'

interface KnowledgeFilterHeadingProps {
title: string
active: boolean
onClear: () => void
}

/** Heading and conditional clear action for a knowledge-list filter. */
export function KnowledgeFilterHeading({ title, active, onClear }: KnowledgeFilterHeadingProps) {
return (
<div className='flex h-5 items-center justify-between'>
<span className={FILTER_SECTION_LABEL_CLASS}>{title}</span>
{active && (
<Button
variant='ghost'
onClick={onClear}
className='-mr-1 h-auto px-1 py-0.5 text-[var(--text-muted)] text-xs hover-hover:text-[var(--text-secondary)]'
>
Clear
</Button>
)}
</div>
)
}
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ vi.mock('@/connectors/registry', () => ({ CONNECTOR_META_REGISTRY: {} }))
vi.mock('@/app/workspace/[workspaceId]/knowledge/[id]/components/base-tags-modal', () => ({
BaseTagsModal: () => null,
}))
vi.mock('@/app/workspace/[workspaceId]/knowledge/components', () => ({
vi.mock('@/app/workspace/[workspaceId]/knowledge/components', async () => ({
...(await import('@/app/workspace/[workspaceId]/knowledge/components/knowledge-filter-heading')),
CreateBaseModal: () => null,
EditKnowledgeBaseModal: () => null,
KnowledgeListContextMenu: () => null,
Expand Down
55 changes: 17 additions & 38 deletions apps/sim/app/workspace/[workspaceId]/knowledge/knowledge.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import { useCallback, useEffect, useMemo, useRef, useState } from 'react'
import type { ChipSelectOption } from '@sim/emcn'
import { Button, ChipConfirmModal, ChipSelect, Tooltip, toast } from '@sim/emcn'
import { ChipConfirmModal, ChipSelect, Tooltip, toast } from '@sim/emcn'
import { Database, FolderPlus, Pencil, Plus, Trash } from '@sim/emcn/icons'
import { createLogger } from '@sim/logger'
import { getErrorMessage } from '@sim/utils/errors'
Expand All @@ -23,7 +23,6 @@ import type {
} from '@/app/workspace/[workspaceId]/components'
import {
EMPTY_CELL_PLACEHOLDER,
FILTER_SECTION_LABEL_CLASS,
OwnerAvatar,
ownerCell,
Resource,
Expand Down Expand Up @@ -70,6 +69,7 @@ import {
DeleteKnowledgeBaseModal,
EditKnowledgeBaseModal,
KnowledgeBaseContextMenu,
KnowledgeFilterHeading,
KnowledgeListContextMenu,
} from '@/app/workspace/[workspaceId]/knowledge/components'
import KnowledgeLoading from '@/app/workspace/[workspaceId]/knowledge/loading'
Expand Down Expand Up @@ -1334,18 +1334,11 @@ function KnowledgeContent() {
() => (
<div className='flex w-[260px] flex-col gap-3 p-3'>
<div className='flex flex-col gap-2'>
<div className='flex h-5 items-center justify-between'>
<span className={FILTER_SECTION_LABEL_CLASS}>Connectors</span>
{connectorFilter.length > 0 && (
<Button
variant='ghost'
onClick={() => setConnectorFilter([])}
className='-mr-1 h-auto px-1 py-0.5 text-[var(--text-muted)] text-xs hover-hover:text-[var(--text-secondary)]'
>
Clear
</Button>
)}
</div>
<KnowledgeFilterHeading
title='Connectors'
active={connectorFilter.length > 0}
onClear={() => setConnectorFilter([])}
/>
<ChipSelect
showSelectedCheck
dropdownWidth='trigger'
Expand All @@ -1358,18 +1351,11 @@ function KnowledgeContent() {
/>
</div>
<div className='flex flex-col gap-2'>
<div className='flex h-5 items-center justify-between'>
<span className={FILTER_SECTION_LABEL_CLASS}>Content</span>
{contentFilter.length > 0 && (
<Button
variant='ghost'
onClick={() => setContentFilter([])}
className='-mr-1 h-auto px-1 py-0.5 text-[var(--text-muted)] text-xs hover-hover:text-[var(--text-secondary)]'
>
Clear
</Button>
)}
</div>
<KnowledgeFilterHeading
title='Content'
active={contentFilter.length > 0}
onClear={() => setContentFilter([])}
/>
<ChipSelect
showSelectedCheck
dropdownWidth='trigger'
Expand All @@ -1383,18 +1369,11 @@ function KnowledgeContent() {
</div>
{memberOptions.length > 0 && (
<div className='flex flex-col gap-2'>
<div className='flex h-5 items-center justify-between'>
<span className={FILTER_SECTION_LABEL_CLASS}>Owner</span>
{ownerFilter.length > 0 && (
<Button
variant='ghost'
onClick={() => setOwnerFilter([])}
className='-mr-1 h-auto px-1 py-0.5 text-[var(--text-muted)] text-xs hover-hover:text-[var(--text-secondary)]'
>
Clear
</Button>
)}
</div>
<KnowledgeFilterHeading
title='Owner'
active={ownerFilter.length > 0}
onClear={() => setOwnerFilter([])}
/>
<ChipSelect
placeholder='All'
showAllOption
Expand Down