Skip to content

improvement(knowledge): skip redundant document resurrection writes - #8000

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/connector-resurrection-guard
Sep 19, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/connector-resurrection-guard

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Restrict document resurrection updates to soft-deleted rows, avoiding redundant writes for documents that are already live.
  • Add a PostgreSQL regression test that verifies tombstone restoration and checks that the resurrection step leaves an active row's version unchanged.

Type of Change

  • Performance improvement

Testing

  • 16 PostgreSQL integration tests passed; the new regression test fails without the guard and passes with it.
  • 216 focused connector unit tests passed.
  • App type check, lint, all 47 audits (including API boundary validation), block registry validation, and docs manifest check passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 19, 2026 2:01am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because it removes only a redundant null-to-null write while preserving tombstone resurrection.

Summary

This PR avoids redundant PostgreSQL tuple updates when the connector rediscovers documents that are already active.

  • Restricts resurrection updates to eligible documents with a non-null deletion timestamp.
  • Adds integration coverage proving tombstoned documents are restored while active documents are not rewritten.

Reviews (1) · Last reviewed commit: "improvement(knowledge): skip redundant d..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 5eece6e into staging Sep 19, 2026
34 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/connector-resurrection-guard branch September 19, 2026 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant