Skip to content

Consolidate EMCN controls and redundant styling options - #7998

Open
BillLeoutsakosvl346 wants to merge 5 commits into
stagingfrom
codex/emcn-consolidation
Open

BillLeoutsakosvl346 wants to merge 5 commits into
stagingfrom
codex/emcn-consolidation

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Consolidates overlapping EMCN controls while keeping existing product layouts, selection values, form behavior, and marketing treatments.

  • Make ChipSelect the single menu-selection API, including rich labels, grouped/searchable options, typed single/multiple selection, trigger refs, and field accessibility. Migrate callers with explicit width, modal, empty-selection, and selection-indicator mappings; remove the duplicate implementation.
  • Share one Radix segmented-control implementation through ChipButtonGroup and its ChipSwitch adapter. Remove redundant styling dimensions and unused Button, Checkbox, and Badge choices.
  • Use existing chip controls for ordinary auth/credential fields and deployment descriptions, keeping specialized native editing surfaces. Reuse shared chip and dropdown styling definitions.

Intentional small visual differences: multiple-selection menus use checkbox rows; segmented groups use zero gap; former large badges use medium sizing; table bulk actions use the adaptive dark fill; migrated fields use chip corners and surfaces while retaining required height constraints. Marketing single-selection checkmarks, form heights, and pricing-toggle treatment are retained.

Validation: all 26 workspace type checks and lint checks pass; import-specifier and API-validation checks pass; 349 EMCN tests and 91 relevant consumer tests pass. External migration/conformance reports and before/after screenshots are kept outside this PR.

This PR stays draft for visual review. The local gallery at /Users/billleoutsakos/sim2/control-fix-prs/reviews/20-emcn-consolidation/index.html contains 71 real-product/marketing examples: 58 before/after pairs and 13 clearly labeled after-only dark examples, with 129 enlarged crops. Added table option menus, file bulk rest/hover, completed export progress, time picker, retained editor, raised-chip modal and permissions InfoCard coverage. The baseline dev server crashed and then stalled; missing/clipped baselines are not presented as comparisons.

Remaining visual gaps are documented externally: Max-plan grouped sandbox menus, the compact access-request control blocked by a missing local DB table, public password/email auth variants and the Slack setup field, the homepage hero, narrow marketing forms, and disabled segmented visuals. Public file/chat auth pages intentionally render light. The homepage is accessible with /?home but remains uncaptured. Existing component tests cover grouped/disabled/keyboard behavior. The user authorized finishing with these limitations; the PR remains draft.

The external symbol-aware migration audit reports zero retired-API references or parse failures. All 37 dynamic references were reviewed explicitly; repository-wide searches and compiler checks independently verify the migration. The broader conformance audit still reports existing design findings plus 13 intentional preserved height/padding or newly recognized field-wrapper findings, documented outside the PR.

Visual review follow-up: restore the standard shared gap between multiple-selection icons/avatars and labels, and remove redundant per-icon margin. Recaptured the affected owner-filter states; the EMCN suite, package type/lint checks and API audit pass again.

Additional real-product verification: Sim chat configured a minimal deployed Function workflow with table auto-run off. Table Run and Re-run both wrote the expected output; View execution confirmed it. Added matching light/dark captures of Run, hover, and Re-run states from the recorded base and current head.

@vercel

vercel Bot commented Sep 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 19, 2026 3:18am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no outstanding correctness, security, or repository-rule violations were identified.

Summary

This PR consolidates EMCN selection and segmented-control APIs, removes redundant component variants, migrates product and marketing consumers to the shared controls, and centralizes chip styling behavior.

  • Replaces ChipDropdown usage with the expanded ChipSelect API, including grouped, searchable, rich-label, and multi-select behavior.
  • Shares one Radix implementation between ChipButtonGroup and ChipSwitch.
  • Removes unused Button, Checkbox, and Badge variants and migrates affected consumers.
  • Reuses shared chip inputs and PasswordInput for authentication, credential, and deployment fields.
  • The follow-up changes correctly complete the password-field deduplication and require searchable text for rich ChipSelect labels.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Consumers[Product and marketing consumers] --> ChipSelect[ChipSelect]
  Consumers --> ChipButtonGroup[ChipButtonGroup]
  Consumers --> ChipSwitch[ChipSwitch adapter]
  Consumers --> ChipInput[ChipInput and PasswordInput]
  ChipSwitch --> ChipButtonGroup
  ChipSelect --> SharedChrome[Shared chip chrome and menu behavior]
  ChipButtonGroup --> SegmentedControl[Shared Radix segmented control]
  ChipInput --> SharedChrome
Loading

Reviews (2) · Last reviewed commit: "fix(emcn): complete password and searcha..."

Comment thread apps/sim/app/f/[token]/public-file-auth.tsx Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 87 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/ee/organization-usage/components/activity-panel.tsx
Comment thread packages/emcn/src/components/chip-select/chip-select.tsx
Comment thread apps/sim/app/f/[token]/public-file-auth.tsx Outdated
Comment thread packages/emcn/src/components/chip/chip-chrome.ts Outdated
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 88 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant