Consolidate EMCN controls and redundant styling options - #7998
BillLeoutsakosvl346 wants to merge 5 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
There was a problem hiding this comment.
All reported issues were addressed across 87 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
Consolidates overlapping EMCN controls while keeping existing product layouts, selection values, form behavior, and marketing treatments.
ChipSelectthe single menu-selection API, including rich labels, grouped/searchable options, typed single/multiple selection, trigger refs, and field accessibility. Migrate callers with explicit width, modal, empty-selection, and selection-indicator mappings; remove the duplicate implementation.ChipButtonGroupand itsChipSwitchadapter. Remove redundant styling dimensions and unused Button, Checkbox, and Badge choices.Intentional small visual differences: multiple-selection menus use checkbox rows; segmented groups use zero gap; former large badges use medium sizing; table bulk actions use the adaptive dark fill; migrated fields use chip corners and surfaces while retaining required height constraints. Marketing single-selection checkmarks, form heights, and pricing-toggle treatment are retained.
Validation: all 26 workspace type checks and lint checks pass; import-specifier and API-validation checks pass; 349 EMCN tests and 91 relevant consumer tests pass. External migration/conformance reports and before/after screenshots are kept outside this PR.
This PR stays draft for visual review. The local gallery at
/Users/billleoutsakos/sim2/control-fix-prs/reviews/20-emcn-consolidation/index.htmlcontains 71 real-product/marketing examples: 58 before/after pairs and 13 clearly labeled after-only dark examples, with 129 enlarged crops. Added table option menus, file bulk rest/hover, completed export progress, time picker, retained editor, raised-chip modal and permissions InfoCard coverage. The baseline dev server crashed and then stalled; missing/clipped baselines are not presented as comparisons.Remaining visual gaps are documented externally: Max-plan grouped sandbox menus, the compact access-request control blocked by a missing local DB table, public password/email auth variants and the Slack setup field, the homepage hero, narrow marketing forms, and disabled segmented visuals. Public file/chat auth pages intentionally render light. The homepage is accessible with
/?homebut remains uncaptured. Existing component tests cover grouped/disabled/keyboard behavior. The user authorized finishing with these limitations; the PR remains draft.The external symbol-aware migration audit reports zero retired-API references or parse failures. All 37 dynamic references were reviewed explicitly; repository-wide searches and compiler checks independently verify the migration. The broader conformance audit still reports existing design findings plus 13 intentional preserved height/padding or newly recognized field-wrapper findings, documented outside the PR.
Visual review follow-up: restore the standard shared gap between multiple-selection icons/avatars and labels, and remove redundant per-icon margin. Recaptured the affected owner-filter states; the EMCN suite, package type/lint checks and API audit pass again.
Additional real-product verification: Sim chat configured a minimal deployed Function workflow with table auto-run off. Table Run and Re-run both wrote the expected output; View execution confirmed it. Added matching light/dark captures of Run, hover, and Re-run states from the recorded base and current head.