refactor(ui): centralize compact icon button sizing in EMCN - #7991
Open
BillLeoutsakosvl346 wants to merge 2 commits into
Open
BillLeoutsakosvl346 wants to merge 2 commits into
BillLeoutsakosvl346 wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Product icon buttons repeatedly set square dimensions and zero padding through consumer classes. Add
Button'siconSizeoption and migrate all 25 matching EMCN Button locations across 10 product files, including the shared workflow action-bar recipe.compactpreserves spacing-based sizing (size-6);compact-fixedpreserves fixed 24px sizing. Both own zero padding while retaining the selectedsizeandvariant's typography, corners, icon strokes and colors. This keeps the original behavior when the browser's font size changes. Consumers retain positioning, canvas width overrides, icons, labels, disabled conditions and handlers. Omitting the new option leaves existing buttons unchanged.The change contains the shared Button update, seven focused test cases and consumer migrations. Landing pages, global CSS, dependencies and audit tooling are excluded.
Validation