Skip to content

v12 - #40

Open
adriaandotcom wants to merge 76 commits into
mainfrom
v12
Open

v12#40
adriaandotcom wants to merge 76 commits into
mainfrom
v12

Conversation

@adriaandotcom

@adriaandotcom adriaandotcom commented May 12, 2023

Copy link
Copy Markdown
Collaborator

Summary

Fixes #97

Prepare public script v12:

Before merging, update beta.js as well or inform customer team 13489e0b-295c-476b-b955-46389fe10895.

Security implications

  • No security impact
  • Has security impact - described as:
    • Query parameter values are never collected by this addition.
    • Name collection is limited to parameters with non-empty values and can be disabled.

Testing

  • Frozen pnpm install passed with Node.js 24.18.0
  • Rebuilt all distribution files
  • Full unit suite passed: 16 tests
  • Focused pageview query suite passed: 4 tests
  • Prettier check passed for the edited source and unit test
  • BrowserStack workflow passed

Checklist

  • Linked to an issue
  • Tested
  • Asked for a review

cursor[bot]

This comment was marked as outdated.

@cursor

This comment was marked as outdated.

@adriaandotcom
adriaandotcom marked this pull request as draft March 3, 2026 10:41
@simple-analytics-ai
simple-analytics-ai Bot marked this pull request as ready for review September 16, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Differentiate paid and organic referral traffic

2 participants