fix: tolerate rounding at adjacent keyframe boundaries - #205
Merged
Merged
Conversation
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 25, 2026
## [2.22.4](v2.22.3...v2.22.4) (2026-09-25) ### Bug Fixes * restore timeline thumbnails after generation succeeds ([#204](#204)) ([75be088](75be088)) * show relevant help for timeline preview errors ([#206](#206)) ([51500d3](51500d3)) * tolerate rounding at adjacent keyframe boundaries ([#205](#205)) ([2c4e2c9](2c4e2c9))
|
🎉 This PR is included in version 2.22.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid adjacent animation segments can fail to load because
0.7 + 3.2evaluates to3.9000000000000004, slightly past the next segment at3.9. Boundary normalisation can retain that rounding difference.Apply the existing timing tolerance when rejecting overlaps. Genuine overlaps still fail validation. The regression test checks playback through the original decimal boundaries.
Verify: Node 22; all 30 keyframe and opacity tests pass, including genuine-overlap rejection.