fix: report clips that fall back to a placeholder - #202
Merged
Merged
Conversation
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 24, 2026
## [2.22.1](v2.22.0...v2.22.1) (2026-09-24) ### Bug Fixes * report clips that fall back to a placeholder ([#202](#202)) ([c1eb51f](c1eb51f))
|
🎉 This PR is included in version 2.22.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an svg, image or video clip can't be displayed, its player draws a placeholder and resolves
load().clip:loadFailedonly fired whenload()rejected, so these failures were never reported.getClipError()also missed svg render failures entirely, because they don't go through the asset loader. A host had no way to tell a working clip from a broken one.Players now record the reason on
loadError, set when they fall back and cleared on each load or reload. The reconciler emitsclip:loadFailedwhen a load or reload finishes withloadErrorset, andgetClipError()checks the player first.load()still resolves, so nothing that awaits it changes. Timelines pick up svg failures through the same error marker failed videos already get.The svg player also had two related problems, fixed here:
reloadAsset()threw on a failed render and left the clip blank. It now falls back likeload()does.Failures are located when they're reported, not when the load started, because clips can move while an asset is still loading.
Verify:
npm test. The five new tests insvg-player.test.tsandedit-load.test.tsfail without the source change.