fix: avoid toSorted in keyframe normalization for older Chromium - #193
Merged
Merged
Conversation
toSorted is Chrome 110+ only; older mobile Chromium throws during edit.load. Use slice().sort with the same comparators so keyframe and opacity paths keep working on older browsers.
Remove delete/restore of Array.prototype.toSorted in unit tests (eslint no-extend-native). Prove slice().sort via unsorted public API inputs instead.
dazzatronus
force-pushed
the
fix/keyframe-tosorted-compat
branch
from
September 24, 2026 06:03
47d7495 to
15ddb9e
Compare
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 25, 2026
## [2.22.2](v2.22.1...v2.22.2) (2026-09-24) ### Bug Fixes * avoid toSorted in keyframe normalization for older Chromium ([#193](#193)) ([5296133](5296133))
|
🎉 This PR is included in version 2.22.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keyframed templates fail to load in browsers without
Array.prototype.toSorted; adding opacity keyframes also fails.Sort the freshly created arrays with the existing comparators. Caller-owned arrays remain unchanged.
Verify:
npm run verify:cipasses on Node 22, including 2,084 tests, lint, typecheck, builds and package contract checks.