Keep commented template inputs Prettier-stable - #7
Merged
Merged
Conversation
Prettier aligns a comment with the line above it, so inputs commented out under `# with:` lost their nesting in any repository that runs Prettier. The extra indentation now follows the #, which Prettier does not touch. Found through a failing Prettier check in annotation-management-system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prettier aligns every comment with the line above it. In the SciFY Node CI and SciFY Security templates, the inputs commented out under
# with:lost their extra indentation, so an uncommented input no longer sat underwith:. annotation-management-system found this: itsprettier --check .failed on a caller in this layout.The extra indentation now follows the
#, which Prettier does not change. Section headers get a second#, so they stay comments when a developer uncomments the whole block.Checked: Prettier changes none of the commented lines, and both templates lint with every input uncommented (11 and 8 inputs). The Laravel template is not affected, because its
with:is not commented out.