Conversation
This makes the stand-alone ComputeSafety of both VecGeom navigators cheaper, as Geant4's own navigator does. - The caller's proposedMaxLength now limits the BVH search: the value is exact below it and a valid lower bound above it, as in G4VoxelSafety. - A query at distance d from the last safety origin returns s0 - d when that covers the bound, without a computation. Every locate drops this cache. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This fixes a stale exit block in the relocating VecGeom navigator. - Entering a daughter adopted the state of the step, which could still carry the block of the volume the previous crossing left, so that volume stayed blocked one step longer than Geant4's rule allows. - Seven of 50000 geantino rays through the ITS outer-barrel services saw up to 9 X0 too much copper because of it; they now agree with TGeo. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sawenzel
force-pushed
the
swenzel/o2sim-vecgeom-safety-boolean
branch
from
October 2, 2026 10:21
6dc8313 to
2beea34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your PR AliceO2Group#15887 cannot be merged as is. You should either run
clang-formatyourself and update the pull request, or merge this PR in yours.You can find the AliceO2 coding conventions at https://github.com/AliceO2Group/CodingGuidelines.