Fix compiler crash for options of transitive dependency types - #8719
Open
fhammerschmidt wants to merge 2 commits into
Open
fhammerschmidt wants to merge 2 commits into
fhammerschmidt wants to merge 2 commits into
Conversation
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8719 +/- ##
==========================================
+ Coverage 78.95% 79.03% +0.08%
==========================================
Files 474 475 +1
Lines 64231 64180 -51
==========================================
+ Hits 50711 50724 +13
+ Misses 13520 13456 -64
🚀 New features to boost your workflow:
|
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
Member
|
@codex review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constructing
Some(Facade.v)or passingFacade.vto an optional argument currently crashes withFatal error: exception Not_foundwhen its type is declared in a transitive dependency whose interface is absent from the consumer's search path.Match directly on the type-declaration lookup so a missing declaration takes the conservative option-wrapping path. Known representations retain their existing behavior, and only
Not_foundfrom the lookup is caught.Add a cross-module build regression that compiles the consumer with only the facade's include path, then executes the generated JavaScript. It covers variants, records, aliases, abstract types, unboxed types, optional arguments, and preservation of
Some(undefined)versusNone. Add focused unit coverage for unavailable declarations and known integer types.Fixes #8687.
Validation:
Not_foundbefore the fix and passes afterward.make testpasses, including formatting, 330 compiler unit tests, 558 runtime tests, build fixtures, and 741 documentation examples.