perf: opt homepage and navbar into React Compiler [codex] - #1369
Merged
jderochervlk merged 5 commits intoSep 21, 2026
Merged
Conversation
jderochervlk
added this pull request to stack #1359
September 19, 2026 19:24
jderochervlk
changed the title
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
guide | 8f0f6c1 | Commit Preview URL Branch Preview URL |
Sep 20 2026, 10:20 PM |
10 tasks
Contributor
Lighthouse baselineCompared with target branch
Download the full Lighthouse reports and baseline Commit |
jderochervlk
marked this pull request as ready for review
September 19, 2026 19:35
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jderochervlk
force-pushed
the
perf/homepage-react-compiler
branch
from
September 19, 2026 20:21
f175479 to
8562055
Compare
12 tasks
jderochervlk
force-pushed
the
perf/homepage-react-compiler
branch
from
September 19, 2026 21:52
8562055 to
781073e
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 781073eb2d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jderochervlk
force-pushed
the
perf/homepage-react-compiler
branch
from
September 19, 2026 22:52
781073e to
2d95442
Compare
jderochervlk
marked this pull request as draft
September 19, 2026 23:02
jderochervlk
force-pushed
the
perf/homepage-react-compiler
branch
from
September 19, 2026 23:50
2d95442 to
c0c2c79
Compare
jderochervlk
force-pushed
the
perf/homepage-react-compiler
branch
from
September 20, 2026 13:24
2265f69 to
a56e6fd
Compare
Share a client-only React 19 annotation-mode compiler configuration between Vite and Vitest. Opt in the intro, install instructions and trusted-by components while keeping other modules and SSR uncompiled. Verify source annotations and actual production client/server output, and cover install prop changes and copy behavior. Record the 427-byte gzip JavaScript cost with unchanged requests, CSS and DOM.
Match generated homepage components in both app/routes and src/components. Update compiler fixtures to their actual locations and retain annotation-only, client-only compilation checks and exclusions.
Point the React Compiler contract tests at the homepage interaction components in src/components.
jderochervlk
force-pushed
the
perf/homepage-react-compiler
branch
from
September 20, 2026 14:44
2e3d74f to
ee7f538
Compare
Compile the shared primary navbar and its stable left and right subtrees in client builds. Extend the compiler contract to verify the source transform, production client artifact, and unchanged server boundary.
jderochervlk
changed the title
Use annotation mode as the component boundary across generated app and src JSX. Compile the homepage composition and copy button while proving eligible unannotated modules remain unchanged.
Contributor
jderochervlk
marked this pull request as ready for review
September 20, 2026 23:01
jderochervlk
changed the title
fhammerschmidt
approved these changes
Sep 21, 2026
This was referenced Sep 21, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete the initial compiler rollout in #1354 on top of #1367. Enable React Compiler in React 19 annotation mode across generated docs application modules. The homepage composition, copy button, intro, install instructions, trusted-by section, and all three
NavbarPrimarycomponent functions opt in with ReScript directives.The Vite plugin now uses
apps/docs/appandapps/docs/srcas a coarse generated-JSX boundary;"use memo"annotations remain the per-function opt-in. Vite and Vitest share the client-only preset. Contract coverage proves eligible unannotated modules remain unchanged, and server rendering remains uncompiled.Artifact checks verify five compiled homepage functions and three compiled navbar functions in the production client while confirming that their server originals stay uncompiled. Browser coverage protects install prop updates, repeated copying and failure recovery, navbar layouts, navigation across shared routes, and lazy search inside the navbar.
Compared with the current #1367 target, initial JavaScript changes from 25 requests / 972,018 raw bytes / 146,252 gzip bytes to 26 requests / 975,598 raw bytes / 147,718 gzip bytes. That is a 3,580-byte raw and 1,466-byte gzip cost, including one shared compiler-runtime request. CSS remains 45,161 raw / 10,362 gzip bytes and the DOM remains 415 elements.
This deliberately includes the shared navbar because it receives frequent scroll and navigation renders. Components imported from dependencies, such as React Router
Link, are not directly annotatable here; compiling their callers can still stabilize the elements passed to them. Lighthouse remains informational with no score threshold.