proposal: support data-* attributes in DOM JSX - #933
Draft
anmonteiro wants to merge 1 commit into
Draft
anmonteiro wants to merge 1 commit into
anmonteiro wants to merge 1 commit into
Conversation
Member
|
Note on digits: server-reason-react's ppx converts data attribute names differently when a digit follows a letter.
server-reason-react puts a dash before every character that is unchanged by If one component is rendered on the server with server-reason-react and hydrated with reason-react, the attribute names will not match. We should agree on one rule. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #230
Proposes supporting custom data attributes directly in JSX:
The PPX generates a local
@mel.objconstructor containing the ordinary props and data attributes supplied at that location. For the props above, the expansion is roughly:The callback checks ordinary props against
ReactDOM.domProps. Here, that constrainsclassNameto string; the shared'aapplies the same constraint to the actual constructor argument. This preserves existing type checks withoutmaintaining a second copy of the DOM prop types in the PPX.
With
[@mel.ignore], Melange erases the ignored callback and compiles the original JSX to:Each JSX expression gets its own constructor, so different elements can supply different sets of attributes. There is no runtime merge, and each prop expression is evaluated once.
Data attribute values are strings, and optional attributes are omitted when their value is
None. Existing property aliases such astype_andariaLabelare preserved. This only applies to DOM elements -- user-defined components continue to use their declared props.related to melange-re/melange#2004.