Skip to content

fix(sandpack): make the Clear button actually reset the preview #8668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dextheking1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(sandpack): make the Clear button actually reset the preview #8668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/components/MDX/Sandpack/NavigationBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,15 +110,15 @@ export function NavigationBar({
}, [isMultiFile, onContainerResize]);

const handleClear = () => {
/**
* resetAllFiles must come first, otherwise
* the previous content will appear for a second
* when the iframe loads.
*
* Plus, it should only prompt if there's any file changes
*/
// Only prompt when there are edits to clear.
if (sandpack.editorState === 'dirty' && confirm('Clear all your edits?')) {
sandpack.resetAllFiles();
// Don't refresh() here. The reset files are pushed to the bundler by
// the file watcher, which recompiles the preview with the original
// code. Refreshing synchronously would reboot the iframe while the
// client still holds the edited files: the reset compile is lost in
// the reboot, so the preview keeps running the edited code (#8657).
return;
}
refresh();
};
Expand Down
Loading