Skip to content

Fix flaky test_one_websocket_per_page after the offline test #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Archmonger merged 1 commit into from
Sep 22, 2026
Merged

Fix flaky test_one_websocket_per_page after the offline test #301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions tests/test_app/tests/test_components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,6 +711,18 @@ def test_offline_component(self):
self.page.wait_for_selector("div:not([hidden]) > #offline")
assert self.page.query_selector("div[hidden] > #online") is not None

# Tearing down the server above severs the offline page's WebSocket, but its
# client (createReconnectingWebSocket) keeps retrying the now-dead port on a
# backoff timer for the rest of the session. All tests share one browser page,
# so that zombie loop keeps firing `new WebSocket()` against the dead port
# during subsequent tests. Any attempt that lands inside another test's
# navigation window leaks a second WebSocket URL and flakes tests such as
# `test_one_websocket_per_page` (observed intermittently on CI as
# "Expected 1 unique WebSocket URL, got 2 ... /offline/"). Navigating away
# destroys this document and cancels its pending reconnect timers, so later
# tests start from a clean state with no lingering client.
self.page.goto("about:blank")

##############
# Form Tests #
##############
Expand Down
Loading