Skip to content

Include the native event timestamp in onHWKeyEvent on Android #58607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bumjung wants to merge 1 commit into from
Closed

Include the native event timestamp in onHWKeyEvent on Android #58607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion ...t-native/ReactAndroid/src/main/java/com/facebook/react/ReactAndroidHWInputDeviceHelper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,13 @@ internal class ReactAndroidHWInputDeviceHelper {
(eventKeyAction == KeyEvent.ACTION_UP || eventKeyAction == KeyEvent.ACTION_DOWN) &&
KEY_EVENTS_ACTIONS.containsKey(eventKeyCode)
) {
dispatchEvent(context, KEY_EVENTS_ACTIONS[eventKeyCode], lastFocusedViewId, eventKeyAction)
dispatchEvent(
context,
KEY_EVENTS_ACTIONS[eventKeyCode],
lastFocusedViewId,
eventKeyAction,
ev.eventTime,
)
}
}

Expand Down Expand Up @@ -58,11 +64,15 @@ internal class ReactAndroidHWInputDeviceHelper {
eventType: String?,
targetViewId: Int,
eventKeyAction: Int = -1,
eventTime: Long = NO_EVENT_TIME,
) {
val event: WritableMap =
WritableNativeMap().apply {
putString("eventType", eventType)
putInt("eventKeyAction", eventKeyAction)
if (eventTime != NO_EVENT_TIME) {
putDouble("eventTime", eventTime.toDouble())
}
if (targetViewId != View.NO_ID) {
putInt("tag", targetViewId)
}
Expand All @@ -71,6 +81,8 @@ internal class ReactAndroidHWInputDeviceHelper {
}

private companion object {
private const val NO_EVENT_TIME: Long = -1

/**
* Contains a mapping between handled KeyEvents and the corresponding navigation event that
* should be fired when the KeyEvent is received.
Expand Down
Loading